Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Integrate AWS-PlantUML into PlantUML #20
Many thanks for this set of sprites and goodies. It's really super-useful.
Actually, it's so useful that we would like to include these to the standard distribution of PlantUML.
This would simply work out-of-the-box, without any other requirement.
Does it sound good to you ?
Responding on mobile so apologies in advance for any spelling errors. First off - thank you for an indispensable diagramming tool, from someone in AppSec who has no free-form diagramming skills, yet has to update/amend diagrams constantly! I'm super flattered that you, and the other users of AWS-PlantUML, have shown interest in this project, and I'm glad you've found it useful. Even more so that you consider it useful enough to integrate into the core PlantUML project - so thanks!
I'm certainly not averse to the idea, and from its inception this project has been something I've put up on GitHub for anyone to use in whatever way is useful to them. In that spirit, and given that this project would not exist without PlantUML in the first place, if the PlantUML project wants to include AWS-PlantUML's dist with the standard distribution, I'd consider it an honor to contribute to the project in that way (a credit in the
I'll be brief(ish) here until I can get in front of my computer to provide more color and context, but I do have some additional thoughts regarding the size impact to the jar and how that could be reduced, how to ensure the included dist meets the majority of use cases while still enabling customization and flexibility for alternative use cases/preferences, etc.. I'll also share a more generic implementation I haven't pushed to a public repo yet, which allows users to similarly create configurable sprites and macros for other icon sets (e.g for other platforms, like Azure or GCP, or for miscellaneous architecural components like Jenkins, nginx, whatever).
Ok, so we've build a new beta https://www.dropbox.com/s/koo42q3d9gxw288/plantuml.jar?dl=0
This is a first draft, so we are open to suggestions!
This was referenced
Nov 5, 2017
added a commit
Nov 13, 2017
Thanks! Super minor, but if you could change to my real name (Chris Passarello), I'd prefer that
Fixed in latest release!
Fixed in latest release, also. I did notice that the case-insensitive path names don't work with the
To clarify, should I also remove the
No problem, done in last beta http://beta.plantuml.net/plantuml.jar
No, do not remove the .puml extension from the file. Leave them XXX.puml.
Yes, an idea... But I'm feeling uncomfortable with it because it means to restore your case-sensitive path name and file name :-(
Let's me explain why this change:
The real reason why we redesign this is that we were concerned by the size of plantuml.jar file which was inflating.
So now, filename/filepath case is really not an issue anymore (because !include could now be smart enough to deal with case, and this could not previously be done because we were before relying on Java case sensitive mecanism of loading .puml from .jar file)
Note that this is completely transparent for end-user. There is also a new -extractstdlib flag so that people can have a look on source code of the library:
And the full stdlib that was using about 2500KB in last plantuml.jar has now decrease to about 770KB (plus 80KB for brotli decompressor code).
Thanks again for your library and sorry about this case confusion, I hope that reverting your change is not a big deal for you.
@arnaudroques no worries - just reverted the pathname changes and related doc changes to
Incidentally, what is the ideal process for getting updates to AWS-PlantUML pushed to PlantUML's stdlib? Do you prefer just doing stdlib updates whenever you do a normal planned release (and only then), or would it be just as easy for me to create a PR to the PlantUML upstream with the generated
Great! We've published a new beta with the last version of aws library. http://beta.plantuml.net/plantuml.jar
Good question about the process: we've just created a new repository https://github.com/plantuml/plantuml-stdlib that contains only the standard library.
This way, you can create PR to this repository whenever you want.