Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative sources #3

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
2 participants
@keithy
Copy link

commented Dec 15, 2017

Milo,

this branch enables the panel to be added multiple times, targeting different composer.json files.

It has not been tested in Nette via DI.

@keithy keithy force-pushed the keithy:alternative_sources branch from dca4404 to 6ec8e27 Dec 15, 2017

@milo

This comment has been minimized.

Copy link
Owner

commented Dec 15, 2017

Hi Keith,

thank you for the contribution.

I can't merge it, because some tabs have been replaced by spaces, and coding style does not match in some places. Additionally, I would solve it in a slightly different way.

If you are ok with it, I can fix it and keep you as an author.

@keithy

This comment has been minimized.

Copy link
Author

commented Dec 15, 2017

On 15 Dec 2017, at 17:37, Miloslav Hůla wrote:
Hi Keith,
thank you for the contribution.
I can't merge it, because some tabs have been replaced by spaces, and coding style does not
match in some places. Additionally, I would solve it in a slightly different way.

Sorry, I just used the netbeans auto-styling feature which I thought was set to psr compatible standards.

If you are ok with it, I can fix it and keep you as an author.

Please do.

Just to let you know about my use case.

We have a lib.json file and a /lib directory with all of the versions for deployment.
Within this required packages are for deployment, and require-dev packages are for db-migration and testing.
The /lib directory is committed to git and is deployed as is to our servers.

We also have a composer.json file and a /vendor directory which developers use.
Within this required packages are for shared development tools,
and require-dev packages are for individual developers to use as they wish.

I thought that specifying the exact .json file (rather than the directory) might match more closely to the workflow of others who use multiple configurations. I load the panel twice, once for each .json file.

thanks for your quick response

K.

@milo milo closed this in a3b036c Dec 18, 2017

@milo

This comment has been minimized.

Copy link
Owner

commented Dec 18, 2017

Hi Keith,
I just released version 1.1.2. Let me know if you hit some issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.