From 3951136dbc6938e5f9fa4e512305a0cba1ff3ef9 Mon Sep 17 00:00:00 2001
From: Emilio Tagua <miloops@gmail.com>
Date: Wed, 21 Dec 2011 11:29:42 -0300
Subject: [PATCH] BILL_TYPE, Y U SO COMPLEX?

---
 lib/bravo/bill.rb       |  4 ++--
 lib/bravo/constants.rb  | 14 ++++++--------
 spec/bravo/bill_spec.rb |  2 +-
 3 files changed, 9 insertions(+), 11 deletions(-)

diff --git a/lib/bravo/bill.rb b/lib/bravo/bill.rb
index c69ecde..90dd18e 100644
--- a/lib/bravo/bill.rb
+++ b/lib/bravo/bill.rb
@@ -25,7 +25,7 @@ def initialize(attrs = {})
     end
 
     def cbte_type
-      Bravo::BILL_TYPE[Bravo.own_iva_cond][iva_cond] ||
+      Bravo::BILL_TYPE[iva_cond] ||
         raise(NullOrInvalidAttribute.new, "Please choose a valid document type.")
     end
 
@@ -120,7 +120,7 @@ def authorized?
     end
 
     def query_bill(iva_cond, cbte_number)
-      cbte_type = Bravo::BILL_TYPE[Bravo.own_iva_cond][iva_cond] ||
+      cbte_type = Bravo::BILL_TYPE[iva_cond] ||
         raise(NullOrInvalidAttribute.new, "Please choose a valid document type.")
 
       response = client.request :fe_comp_consultar do
diff --git a/lib/bravo/constants.rb b/lib/bravo/constants.rb
index 27f11c9..635b949 100644
--- a/lib/bravo/constants.rb
+++ b/lib/bravo/constants.rb
@@ -36,13 +36,11 @@ module Bravo
   ALIC_IVA = [["03", 0], ["04", 0.105], ["05", 0.21], ["06", 0.27]]
 
   BILL_TYPE = {
-    :responsable_inscripto => {
-      :responsable_inscripto => "01",
-      :consumidor_final => "06",
-      :exento => "06",
-      :responsable_monotributo => "06",
-      :nota_credito_a => "03",
-      :nota_credito_b => "08"
-    }
+    :responsable_inscripto => "01",
+    :consumidor_final => "06",
+    :exento => "06",
+    :responsable_monotributo => "06",
+    :nota_credito_a => "03",
+    :nota_credito_b => "08"
   }
 end
diff --git a/spec/bravo/bill_spec.rb b/spec/bravo/bill_spec.rb
index f880260..5ee660b 100644
--- a/spec/bravo/bill_spec.rb
+++ b/spec/bravo/bill_spec.rb
@@ -84,7 +84,7 @@
       detail["FchVtoPago"].should   == "20111210"
     end
 
-    Bravo::BILL_TYPE[Bravo.own_iva_cond].keys.each do |target_iva_cond|
+    Bravo::BILL_TYPE.keys.each do |target_iva_cond|
       it "should authorize a valid bill for #{target_iva_cond.to_s}" do
         @bill.net = 1000000
         @bill.aliciva_id = 2