From 0ce100171e9863b0ba82dc004c772ae2dcd74757 Mon Sep 17 00:00:00 2001 From: Joshua Hull Date: Tue, 20 Apr 2010 14:42:20 -0400 Subject: [PATCH] Fix up bundle init --gemspec --- lib/bundler/rubygems_ext.rb | 14 +++++++++++--- spec/other/init_spec.rb | 5 +++-- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/lib/bundler/rubygems_ext.rb b/lib/bundler/rubygems_ext.rb index 647bfe12bbb..52b352ce912 100644 --- a/lib/bundler/rubygems_ext.rb +++ b/lib/bundler/rubygems_ext.rb @@ -27,8 +27,16 @@ def git_version def to_gemfile(path = nil) gemfile = "source :gemcutter\n" - gemfile << dependencies_to_gemfile(dependencies) - gemfile << dependencies_to_gemfile(development_dependencies, :development) + gemfile << dependencies_to_gemfile(nondevelopment_dependencies) + unless development_dependencies.empty? + gemfile << "\n" + gemfile << dependencies_to_gemfile(development_dependencies, :development) + end + gemfile + end + + def nondevelopment_dependencies + dependencies - development_dependencies end def add_bundler_dependencies(*groups) @@ -47,7 +55,7 @@ def add_bundler_dependencies(*groups) def dependencies_to_gemfile(dependencies, group = nil) gemfile = '' if dependencies.any? - gemfile << "group #{group} do\n" if group + gemfile << "group :#{group} do\n" if group dependencies.each do |dependency| gemfile << ' ' if group gemfile << %|gem "#{dependency.name}"| diff --git a/spec/other/init_spec.rb b/spec/other/init_spec.rb index 912a90c684b..51fe8004855 100644 --- a/spec/other/init_spec.rb +++ b/spec/other/init_spec.rb @@ -32,8 +32,9 @@ gemfile = bundled_app("Gemfile").read gemfile.should =~ /source :gemcutter/ - gemfile.should =~ /gem "rack", "= 1.0.1"/ - gemfile.should =~ /gem "rspec", "= 1.2"/ + gemfile.scan(/gem "rack", "= 1.0.1"/).size.should == 1 + gemfile.scan(/gem "rspec", "= 1.2"/).size.should == 1 + gemfile.scan(/group :development/).size.should == 1 end end \ No newline at end of file