New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support tls/ssl connection to etcd (#7703) #17012
Conversation
/assign @yanliang567 |
thanks for the contribution @ownbylichaobao ~ welcome! |
Codecov Report
@@ Coverage Diff @@
## master #17012 +/- ##
==========================================
+ Coverage 81.15% 81.17% +0.01%
==========================================
Files 456 457 +1
Lines 72712 72898 +186
==========================================
+ Hits 59011 59173 +162
- Misses 10966 10985 +19
- Partials 2735 2740 +5
|
@ownbylichaobao E2e jenkins job failed, comment |
/run-checks |
first time contributor can not run ci automatically, simply let me know when you are ready to run ci @ownbylichaobao |
@ownbylichaobao ut workflow job failed, comment |
rerun ut |
Hello ownbylichaobao, you are not in the organization, so you do not have the permission to rerun the workflow, please contact |
ok |
|
@ownbylichaobao E2e jenkins job failed, comment |
/run-checks |
Hi, I'm ready to run ci @xiaofan-luan |
/assign @xiaofan-luan |
good job! overall is good to me, thanks @ownbylichaobao |
@ownbylichaobao ut workflow job failed, comment |
Hi ,looks like some tests failed. I don't think that's my problem. Do you need to run again? @xiaofan-luan |
Will do~ looks like there are some race condition on it. |
not support yet @xiaofan-luan Now that it looks like unit test coverage has dropped, I added some test code and resubmitted it |
Signed-off-by: lichaobao <1527563274@qq.com>
@ownbylichaobao E2e jenkins job failed, comment |
/run-checks |
Cool, if we can open another pr for auto-tls that would be great~ Just take a look on etcd tls is enabled and find a part about it |
👌 |
@ownbylichaobao ut workflow job failed, comment |
Hi ,it fails again. @xiaofan-luan |
Run failed again, it looks like the download dependency crashed |
Will just ignore macOS pipeline for now since it's not the pr issue~ |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ownbylichaobao, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
👌 |
squash merge it due to the unstable of macos pipeline~ |
Support tls/ssl connection to etcd
Signed-off-by: lichaobao 1527563274@qq.com
Resolves: #7703