Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix observers may update current target to a unfinished next target #21107

Merged
merged 1 commit into from Dec 12, 2022
Merged

Fix observers may update current target to a unfinished next target #21107

merged 1 commit into from Dec 12, 2022

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Dec 9, 2022

Signed-off-by: yah01 yang.cen@zilliz.com
/kind bug
related #21093
related #21026

@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label Dec 9, 2022
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 9, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Dec 9, 2022
@mergify
Copy link
Contributor

mergify bot commented Dec 9, 2022

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Dec 9, 2022

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Dec 12, 2022

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Dec 12, 2022

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Dec 12, 2022
@yah01 yah01 changed the title Keep next target while updating current target Fix observers may update current target to a unfinished next target Dec 12, 2022
@codecov
Copy link

codecov bot commented Dec 12, 2022 •
edited

Codecov Report

Merging #21107 (a2bf823) into master (a7b24cb) will decrease coverage by 0.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21107      +/-   ##
==========================================
- Coverage   82.10%   82.09%   -0.02%     
==========================================
  Files         706      706              
  Lines       95042    95051       +9     
==========================================
- Hits        78035    78029       -6     
- Misses      14010    14020      +10     
- Partials     2997     3002       +5
Impacted Files Coverage Δ
internal/querycoordv2/observers/target_observer.go 85.85% <75.00%> (-2.44%) ⬇️
internal/querycoordv2/meta/target_manager.go 87.58% <100.00%> (+0.17%) ⬆️
internal/querycoordv2/utils/test.go 88.33% <0.00%> (-11.67%) ⬇️
internal/indexnode/taskinfo_ops.go 82.08% <0.00%> (-8.96%) ⬇️
internal/distributed/indexcoord/client/client.go 53.29% <0.00%> (-3.85%) ⬇️
internal/indexnode/task_scheduler.go 86.30% <0.00%> (-2.74%) ⬇️
internal/util/grpcclient/client.go 76.11% <0.00%> (-1.50%) ⬇️
internal/indexcoord/flush_segment_watcher.go 95.93% <0.00%> (-1.22%) ⬇️
internal/mq/msgstream/mq_msgstream.go 79.28% <0.00%> (-1.15%) ⬇️
... and 7 more

@mergify mergify bot added the ci-passed label Dec 12, 2022
congqixia
congqixia approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 5ba1a94 into milvus-io:master Dec 12, 2022
@yah01 yah01 mentioned this pull request Dec 13, 2022
Closed
1 task
yah01 added a commit to yah01/milvus that referenced this pull request Dec 19, 2022
@yah01
Fix observers may update current target to a unfinished next target (m…
7a43aa9 
…ilvus-io#21107)

Signed-off-by: yah01 <yang.cen@zilliz.com>

Signed-off-by: yah01 <yang.cen@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Dec 19, 2022
@yah01
Fix observers may update current target to a unfinished next target (#…
69b7eeb 
…21107) (#21280)

Signed-off-by: yah01 <yang.cen@zilliz.com>

Signed-off-by: yah01 <yang.cen@zilliz.com>

Signed-off-by: yah01 <yang.cen@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@sunby sunby Awaiting requested review from sunby

@yanliang567 yanliang567 Awaiting requested review from yanliang567

Assignees

@congqixia congqixia

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yah01 @sre-ci-robot @congqixia