New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid deleting entities by non-pk field (#21459) #21472

Merged

sre-ci-robot merged 1 commit into milvus-io:2.2.0 from longjiquan:cp-de9ed426230c6c59af6d03b32457817effb8ac74

Jan 10, 2023

Contributor

longjiquan commented Dec 30, 2022

Signed-off-by: longjiquan jiquan.long@zilliz.com
issue: #21458

sre-ci-robot requested review from czs007 and xiaocai2333

December 30, 2022 09:17

sre-ci-robot added the size/M label

mergify bot added the dco-passed label

codecov bot commented Dec 30, 2022 •

edited

Codecov Report

Merging #21472 (dc94fb6) into 2.2.0 (225c2b7) will increase coverage by 28.53%.
The diff coverage is n/a.

❗ Current head dc94fb6 differs from pull request most recent head 434e069. Consider uploading reports for the commit 434e069 to get more accurate results

@@             Coverage Diff             @@
##            2.2.0   #21472       +/-   ##
===========================================
+ Coverage   39.51%   68.05%   +28.53%     
===========================================
  Files         264      689      +425     
  Lines       16675    94534    +77859     
===========================================
+ Hits         6589    64331    +57742     
- Misses      10008    27048    +17040     
- Partials       78     3155     +3077

Impacted Files	Coverage Δ
internal/storage/data_codec.go	`52.48% <0.00%> (ø)`
internal/mq/mqimpl/rocksmq/client/error.go	`68.42% <0.00%> (ø)`
internal/mq/mqimpl/rocksmq/client/consumer_impl.go	`96.15% <0.00%> (ø)`
internal/distributed/indexcoord/client/client.go	`53.29% <0.00%> (ø)`
internal/querycoordv2/session/stats.go	`100.00% <0.00%> (ø)`
internal/querynode/watch_dm_channels_task.go	`62.19% <0.00%> (ø)`
internal/querynode/segment.go	`20.76% <0.00%> (ø)`
internal/datacoord/compaction.go	`89.05% <0.00%> (ø)`
internal/querycoordv2/utils/types.go	`55.20% <0.00%> (ø)`
internal/proxy/error.go	`93.33% <0.00%> (ø)`
... and 502 more

Contributor

mergify bot commented Dec 30, 2022

@longjiquan ut workflow job failed, comment rerun ut can trigger the job again.

Contributor Author

longjiquan commented Jan 3, 2023

rerun ut

Contributor

mergify bot commented Jan 3, 2023

@longjiquan ut workflow job failed, comment rerun ut can trigger the job again.

longjiquan force-pushed the cp-de9ed426230c6c59af6d03b32457817effb8ac74 branch from bdbb3a8 to 4fda416 Compare

January 3, 2023 06:23

Contributor

mergify bot commented Jan 3, 2023

@longjiquan ut workflow job failed, comment rerun ut can trigger the job again.

Contributor Author

longjiquan commented Jan 3, 2023

rerun ut

Contributor

mergify bot commented Jan 3, 2023

@longjiquan ut workflow job failed, comment rerun ut can trigger the job again.

longjiquan force-pushed the cp-de9ed426230c6c59af6d03b32457817effb8ac74 branch from 4fda416 to 434e069 Compare

January 4, 2023 07:15

Contributor

mergify bot commented Jan 4, 2023

@longjiquan ut workflow job failed, comment rerun ut can trigger the job again.


          Forbid deleting entities by non-pk field (milvus-io#21459)

ae7c36b

Signed-off-by: longjiquan <jiquan.long@zilliz.com>

longjiquan force-pushed the cp-de9ed426230c6c59af6d03b32457817effb8ac74 branch from 434e069 to ae7c36b Compare

January 4, 2023 12:20

mergify bot added the ci-passed label

Contributor

czs007 commented Jan 10, 2023

/approve
/lgtm

sre-ci-robot assigned czs007

sre-ci-robot added the lgtm label

Contributor

sre-ci-robot commented Jan 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~internal/proxy/OWNERS~~ [czs007]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot added the approved label

sre-ci-robot merged commit d78b17f into milvus-io:2.2.0

longjiquan deleted the cp-de9ed426230c6c59af6d03b32457817effb8ac74 branch

March 8, 2023 05:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment