Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup config file for embedded etcd #22076

Merged
merged 1 commit into from Feb 9, 2023

Conversation

xiaofan-luan
Copy link
Contributor

fix #22065
Signed-off-by: xiaofan-luan xiaofan.luan@zilliz.com

Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
@sre-ci-robot sre-ci-robot added approved size/S Denotes a PR that changes 10-29 lines. labels Feb 8, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Feb 8, 2023
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #22076 (9c2ede9) into 2.2.0 (2e4d64e) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #22076      +/-   ##
==========================================
+ Coverage   81.77%   81.80%   +0.02%     
==========================================
  Files         700      700              
  Lines       98163    98162       -1     
==========================================
+ Hits        80277    80300      +23     
+ Misses      14769    14754      -15     
+ Partials     3117     3108       -9     
Impacted Files Coverage Δ
internal/util/paramtable/base_table.go 85.08% <ø> (+0.34%) ⬆️
internal/util/sessionutil/session_util.go 80.52% <0.00%> (-2.84%) ⬇️
internal/proxy/channels_time_ticker.go 76.11% <0.00%> (-2.24%) ⬇️
internal/querycoordv2/session/cluster.go 67.98% <0.00%> (-1.48%) ⬇️
internal/datacoord/segment_manager.go 86.74% <0.00%> (-1.39%) ⬇️
internal/querycoordv2/checkers/channel_checker.go 80.67% <0.00%> (-0.85%) ⬇️
internal/mq/msgstream/mq_msgstream.go 79.06% <0.00%> (-0.43%) ⬇️
internal/querynode/shard_cluster.go 95.85% <0.00%> (-0.41%) ⬇️
internal/querynode/impl.go 66.61% <0.00%> (+0.16%) ⬆️
internal/mq/mqimpl/rocksmq/server/rocksmq_impl.go 83.68% <0.00%> (+0.39%) ⬆️
... and 15 more

@mergify mergify bot added the ci-passed label Feb 8, 2023
@czs007
Copy link
Contributor

czs007 commented Feb 9, 2023

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit d842711 into milvus-io:2.2.0 Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants