Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash issue of bulkinsert by invalid numpy array file #24480

Merged
merged 1 commit into from May 29, 2023
Merged

Fix crash issue of bulkinsert by invalid numpy array file #24480

merged 1 commit into from May 29, 2023

Conversation

yhmo
Copy link
Contributor

@yhmo yhmo commented May 29, 2023 •
edited

@yhmo
Fix crash issue of bulkinsert by invalid numpy array file
099ccda 
Signed-off-by: yhmo <yihua.mo@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label May 29, 2023
@mergify mergify bot added the dco-passed DCO check passed. label May 29, 2023
@codecov
Copy link

codecov bot commented May 29, 2023 •
edited

Codecov Report

Merging #24480 (099ccda) into 2.2.0 (c314d54) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #24480      +/-   ##
==========================================
- Coverage   80.84%   80.84%   -0.01%     
==========================================
  Files         759      759              
  Lines      106229   106235       +6     
==========================================
+ Hits        85885    85889       +4     
- Misses      17024    17030       +6     
+ Partials     3320     3316       -4
Impacted Files Coverage Δ
internal/util/importutil/numpy_parser.go 91.84% <100.00%> (+0.07%) ⬆️

... and 14 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 29, 2023
congqixia
congqixia approved these changes May 29, 2023
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 1dde46b into milvus-io:2.2.0 May 29, 2023
11 checks passed
yhmo added a commit to yhmo/milvus that referenced this pull request May 30, 2023
@yhmo
Fix crash issue of bulkinsert by invalid numpy array file (milvus-io#…
0d21f5a 
…24480)

Signed-off-by: yhmo <yihua.mo@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request May 31, 2023
@yhmo
Fix crash issue of bulkinsert by invalid numpy array file (#24480) (#…
0d0e97a 
…24528)

Signed-off-by: yhmo <yihua.mo@zilliz.com>
@yhmo yhmo deleted the 222 branch May 31, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@congqixia congqixia

Labels
approved ci-passed dco-passed DCO check passed. lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yhmo @sre-ci-robot @congqixia