Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce copy while inserting data to growing segment #24492

Merged
merged 1 commit into from May 30, 2023

Conversation

yah01
Copy link
Member

@yah01 yah01 commented May 29, 2023

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label May 29, 2023
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label May 29, 2023
@mergify mergify bot added the dco-passed DCO check passed. label May 29, 2023
Signed-off-by: yah01 <yah2er0ne@outlook.com>
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #24492 (69081fe) into 2.2.0 (1dde46b) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #24492      +/-   ##
==========================================
- Coverage   80.85%   80.84%   -0.02%     
==========================================
  Files         759      759              
  Lines      106243   106243              
==========================================
- Hits        85904    85887      -17     
- Misses      17026    17042      +16     
- Partials     3313     3314       +1     
Impacted Files Coverage Δ
internal/core/src/segcore/SegmentGrowingImpl.cpp 61.30% <100.00%> (ø)

... and 13 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 29, 2023
@jiaoew1991
Copy link
Contributor

/lgtm

@yah01
Copy link
Member Author

yah01 commented May 30, 2023

master branch already optimized, no need to cherry-pick

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 421d29c into milvus-io:2.2.0 May 30, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants