Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug for expression boundary #7339

Merged
merged 1 commit into from Aug 28, 2021
Merged

Fix bug for expression boundary #7339

merged 1 commit into from Aug 28, 2021

Conversation

xiaocai2333
Copy link
Contributor

Signed-off-by: cai.zhang cai.zhang@zilliz.com
issue: #7142

@xiaocai2333
Fix bug for expression boundary
4915d58 
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 27, 2021
@xiaocai2333
Copy link
Contributor Author

/uncc @FluorineDog
/cc @xiaofan-luan

@sre-ci-robot sre-ci-robot requested review from xiaofan-luan and removed request for FluorineDog August 27, 2021 09:35
@fishpenguin
Copy link
Contributor

/lgtm

@codecov
Copy link

codecov bot commented Aug 27, 2021 •
edited

Codecov Report

Merging #7339 (4915d58) into master (14391fe) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7339      +/-   ##
==========================================
+ Coverage   48.08%   48.17%   +0.09%     
==========================================
  Files         249      249              
  Lines       30871    30871              
==========================================
+ Hits        14843    14873      +30     
+ Misses      14311    14286      -25     
+ Partials     1717     1712       -5
Impacted Files Coverage Δ
...nternal/util/rocksmq/client/rocksmq/client_impl.go 64.51% <0.00%> (ø)
internal/rootcoord/meta_table.go 90.76% <0.00%> (+0.17%) ⬆️
internal/rootcoord/task.go 80.79% <0.00%> (+1.98%) ⬆️
internal/querycoord/task.go 71.41% <0.00%> (+2.17%) ⬆️

@mergify mergify bot added the ci-passed label Aug 27, 2021
@wxyucs
Copy link
Member

wxyucs commented Aug 28, 2021

/approve

1 similar comment
@wxyucs
Copy link
Member

wxyucs commented Aug 28, 2021

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: scsven, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: scsven, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 880aa54 into milvus-io:master Aug 28, 2021
@xiaocai2333 xiaocai2333 deleted the fix_expr_bug branch September 16, 2021 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fishpenguin fishpenguin Awaiting requested review from fishpenguin

@xiaofan-luan xiaofan-luan Awaiting requested review from xiaofan-luan

Assignees

@fishpenguin fishpenguin

Labels
approved ci-passed lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xiaocai2333 @fishpenguin @wxyucs @sre-ci-robot