Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply for msgstream from pool when creating collection #7738

Merged

Conversation

cydrain
Copy link
Contributor

@cydrain cydrain commented Sep 10, 2021

Signed-off-by: yudong.cai yudong.cai@zilliz.com

Resolves: #7323

@cydrain cydrain self-assigned this Sep 10, 2021
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Sep 10, 2021
@cydrain
Copy link
Contributor Author

cydrain commented Sep 10, 2021

/assign @xiaofan-luan

@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #7738 (7d559b0) into master (46871fc) will increase coverage by 0.08%.
The diff coverage is 90.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7738      +/-   ##
==========================================
+ Coverage   77.68%   77.77%   +0.08%     
==========================================
  Files         250      250              
  Lines       32102    32135      +33     
==========================================
+ Hits        24940    24993      +53     
+ Misses       5104     5085      -19     
+ Partials     2058     2057       -1     
Impacted Files Coverage Δ
internal/querynode/flow_graph_filter_dm_node.go 92.39% <ø> (-0.25%) ⬇️
internal/rootcoord/param_table.go 62.36% <71.42%> (+0.73%) ⬆️
internal/rootcoord/timeticksync.go 95.36% <84.61%> (-0.99%) ⬇️
internal/rootcoord/dml_channels.go 90.56% <90.38%> (+27.10%) ⬆️
internal/datanode/data_sync_service.go 91.36% <100.00%> (ø)
internal/datanode/flow_graph_dd_node.go 100.00% <100.00%> (ø)
...nternal/datanode/flow_graph_dmstream_input_node.go 100.00% <100.00%> (ø)
internal/datanode/flow_graph_insert_buffer_node.go 83.60% <100.00%> (+0.16%) ⬆️
internal/querynode/flow_graph_query_node.go 82.19% <100.00%> (+0.24%) ⬆️
internal/rootcoord/meta_table.go 90.61% <100.00%> (+0.01%) ⬆️
... and 14 more

@mergify mergify bot added the ci-passed label Sep 10, 2021
@cydrain cydrain force-pushed the caiyd_7323_apply_channel_from_pool branch from 60c1695 to 563ca76 Compare September 11, 2021 06:17
@mergify mergify bot removed the ci-passed label Sep 11, 2021
@cydrain
Copy link
Contributor Author

cydrain commented Sep 11, 2021

/hold

@mergify mergify bot added the ci-passed label Sep 11, 2021
@cydrain cydrain force-pushed the caiyd_7323_apply_channel_from_pool branch from 563ca76 to 6b00734 Compare September 13, 2021 15:02
@mergify mergify bot removed the ci-passed label Sep 13, 2021
@cydrain cydrain force-pushed the caiyd_7323_apply_channel_from_pool branch 2 times, most recently from 6bd20b0 to c07ce49 Compare September 16, 2021 13:48
@mergify mergify bot added the ci-passed label Sep 16, 2021
@cydrain
Copy link
Contributor Author

cydrain commented Sep 16, 2021

/unhold

@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
@cydrain cydrain force-pushed the caiyd_7323_apply_channel_from_pool branch from c07ce49 to 7d559b0 Compare September 17, 2021 14:53
@sre-ci-robot sre-ci-robot removed the lgtm label Sep 17, 2021
@mergify mergify bot removed the ci-passed label Sep 17, 2021
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cydrain, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit d10c6ab into milvus-io:master Sep 18, 2021
@cydrain cydrain deleted the caiyd_7323_apply_channel_from_pool branch September 18, 2021 02:23
xiyichan pushed a commit to xiyichan/milvus that referenced this pull request Sep 26, 2021
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants