Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe collection by collection ID #9471

Merged
merged 1 commit into from Oct 9, 2021

Conversation

longjiquan
Copy link
Contributor

Signed-off-by: dragondriver jiquan.long@zilliz.com
/cc @czs007 @cydrain
issue: #8867

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Oct 8, 2021
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #9471 (84cb954) into master (2711b53) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9471      +/-   ##
==========================================
+ Coverage   79.90%   80.01%   +0.11%     
==========================================
  Files         248      248              
  Lines       45518    45518              
==========================================
+ Hits        36369    36423      +54     
+ Misses       7083     7029      -54     
  Partials     2066     2066              
Impacted Files Coverage Δ
internal/proxy/task.go 74.41% <100.00%> (+1.24%) ⬆️
...nternal/util/rocksmq/client/rocksmq/client_impl.go 84.21% <0.00%> (-3.51%) ⬇️
internal/util/flowgraph/node.go 72.47% <0.00%> (-0.92%) ⬇️
internal/proxy/impl.go 81.35% <0.00%> (-0.24%) ⬇️
...ternal/util/rocksmq/server/rocksmq/rocksmq_impl.go 76.32% <0.00%> (-0.17%) ⬇️
internal/querycoord/querynode.go 63.66% <0.00%> (ø)
internal/rootcoord/root_coord.go 81.42% <0.00%> (+0.17%) ⬆️
internal/rootcoord/task.go 82.53% <0.00%> (+0.48%) ⬆️
internal/rootcoord/meta_table.go 80.92% <0.00%> (+0.51%) ⬆️
... and 3 more

@mergify mergify bot added the ci-passed label Oct 8, 2021
@wxyucs
Copy link
Member

wxyucs commented Oct 8, 2021

/approve

@czs007
Copy link
Contributor

czs007 commented Oct 9, 2021

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, DragonDriver, scsven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 302ca04 into milvus-io:master Oct 9, 2021
@claireyuw
Copy link

Does this PR incur user doc updates? @DragonDriver @scsven @czs007

@longjiquan longjiquan deleted the fix-8867-check-id branch December 21, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants