Meeting Notes: Development, Aug 20 2019
Notes are truncated, and conversations sorted based on topic and not always chronological. Quotes are edited for brevity and clarity, and not always exact.
(apologies if I missed someone - submit a PR or contact @lehnberg to add)
Agenda points & Actions
- yeastplume: Most visible over the past couple of weeks have been: 1) @antiochp and changes to the kernel serialization formats in anticipation of variable kernel sizes and ultimately relative kernel locks, both of which have shiny new RFCs for consumption. These are carefully done so as to not have repeats of our pre-hf incompatibilities.
- antiochp: It's what's taking so long (that and writing RFCs), although just writing it down like this is making us think about all the places we need to be careful - so it's worth it.
- yeastplume: 2) the introduction of a secure API mode for the wallet json-rpc APIs, in anticipation of full lifecycle functions (create wallet, open wallet, etc) within in the API. That took me most of the last couple of weeks, and I'm moving on to actually implementing these functions next, which should hopefully be quick(ish) given the groundwork has been done over a few very large wallet PRs. 3) @tromp has been doing some solver related work as well (which I'll let him fill us in on)
- tromp: I've been working on integrating photon's GPU speedups back into my repo, which i'll be tweaking over the next week or so and then we'll update the reference miner.
2. Agenda review
Proposed agenda accepted.
3. Action point follow-up
4. Security review status
- j01tz: Coinspect confirmed receiving our remediation report at the end of last week. Hoping to hear back from them soon with any updates.
- yeastplume: Thanks again for all your work here, hopefully we should have this entire issue closed off soon.
5. Status of open RFCs
5.1 Security process
- antiochp: @lehnberg mentioned numbering and merging the security RFC earlier, should we do it?
Yestplume, Antioch, Quentin, Lehnberg in favour.
5.2 Wallet lifecycle API
- yeastplume: It's also time to merge/number this one, unless anyone has any outstanding objections?
- lehnberg: Do you know if anyone has actually reviewed it? I see no discussions or reviews on the pull request. Would be nice for audit and posterity to get some +1s on the PR as well.
- yeastplume: @DavidBurkett has, and it's had sufficient mention in the wallet dev channel. Agreed though, if anyone who's looked at it silently would like to add some +1s.
- quentinlesceller: Will do this afternoon.
- antiochp: I'll take a look as well.
5.3 Variable size kernels
- antiochp: Hoping to have this out of WIP in the next day or so - just need to document the migration process etc. It's reviewable today.
6. Release planning
yeastplume: Let's have a discussion on what's going into the next minor releases of the wallet and node. I admit not having had the discussion in the wallet subteam yet, but in my head the next wallet release (2.1.0) will include the new secure wallet lifecycle API, and I'd also like to address one or two long-standing issues, though which ones is open for discussion. I'm thinking mimblewimble/grin-wallet#169, but it requires some additions to the node API as well.
antiochp: I'd personally like to get protocol version 2 kernels working on p2p layer (without breaking any wallet apis) - i.e. saving bytes on unnecessary fee and lock_height and allowing them to be variable size, even if we're not maintaining them in the MMR like that just yet.
quentinlesceller: I'd like to add mimblewimble/grin#2966 in there if possible. Still needs some work though.
lehnberg: Do we want to target it based on scope (stuff being ready and then when ready we release) or time (setting a deadline for release and releasing it with whatever is ready)? I know we’ve been doing it on scope before, just wanting to confirm that this is still desired.
- yeastplume: I think scope until there's a need for a time-based deadline (HF2).
- quentinlesceller: Agreed.
- antiochp: I'd say scope but keep scope limited.
lehnberg: Maybe we could do some planning on a github issue on
/grin-pmor something with a cut-off?
- yeastplume: Yep, sounds like a plan.
- antiochp: I'd say by the gov meeting next week, (for scope).
- lehnberg: Sounds good, we can finalize it asynch over the github issue (I’ll create one).
lehnberg: Also regarding HF2, do we want to set some “rough” targets / rules here? feels like it’s almost just around the corner! If HF2 is ~ Jan 15 2020, when is feature freeze? And if feature freeze date is x, when is scope freeze? etc
- yeastplume: Think they'd still be very rough at this stage, but I think this time we want the scope defined very well in advance? Like 2-3 months at least? End Oct would seem like when we'd want to have scope frozen, i.e. all issues targeted for the HF tagged in Github.
- antiochp: I think features should probably be done by end of Nov as well as its leading into holiday time. So maybe end of Oct for scope then end of Nov for features (assuming some features are already being worked on prior to end of Oct).
- lehnberg: And then december is beta / release candidate modes plus holidays etc. Floonet hard fork practice.
- antiochp: And first 2 weeks of Jan gives people time to upgrade.
yeastplume: So, 2.1.0 scope to be finalized next week via grin-pm issue/subteams. Timeline for HF release as discussed here agreed and to be documented.
- lehnberg: Yep. And with it being Aug 20 today, it means we have roughly 2 months before we’re in full hard fork mode. So anyone who wants to get something into a 2.1.0 or a 2.2.0 keep this in mind please, there’s ~8-9 weeks to get it done.
- yeastplume: That would mean we want to get 2.1.0 out before then.
- antiochp: If we can finalize scope by this time next week - then maybe we err on scoping for a couple of weeks beyond that? i.e. not much more than that?
- lehnberg: It might be a while after 2.1.0 is out for “regular” non-consensus improvements to be included in a release.
- yeastplume: As long as we keep our heads and plan scopes sensibly, I think we can get away with allowing some non-HF related changes into 3.0.0.
- lehnberg: That would ease things for sure.
- antiochp: Yeah - we just don't want to be piling them in during last week of Nov.
Meeting in agreement.
7. Other questions