Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable faster sync #29

Merged
merged 3 commits into from Dec 18, 2019
Merged

Conversation

@antiochp
Copy link
Member

@antiochp antiochp commented Oct 29, 2019

RFC proposal for enabling faster sync via "batched" subtrees of the output PMMR.

We have a way forward to verify subtrees of the output PMMR without necessarily having to wait to download the full output and kernel PMMRs. This lets us download subtrees of the output PMMR from multiple peers in parallel, verifying them as they arrive.
Plan is to eventually remove the existing bottleneck around the sync process where we are currently limited to waiting for a single monolithic txhashset.zip download from a single, potentially slow or unreliable peer.

Splitting this download across multiple peers and allowing these to happen in parallel will allow the whole sync process to be faster and more robust.

@antiochp antiochp marked this pull request as ready for review Oct 29, 2019
@antiochp
Copy link
Member Author

@antiochp antiochp commented Oct 29, 2019

Moved from draft and into review.

@antiochp antiochp mentioned this pull request Nov 4, 2019
2 tasks
@cadmuspeverell
Copy link

@cadmuspeverell cadmuspeverell commented Nov 27, 2019

How very ironic. I offered this exact design many months ago in mimblewimble/grin#2837 - and yet it was you who sent me a long cutting message in gitter for a mere mention of adding a UTXO commitment. I'm elated to see progress finally being made - tho I do wish I wasn't promptly shooed away. We may have been 6 months closer to seeing these changes in action...

@antiochp
Copy link
Member Author

@antiochp antiochp commented Nov 27, 2019

@cadmuspeverell Good to see you around again. I wouldn't call it ironic necessarily - more that we took the time to think it through fully (both #2837 and other similar proposals).

- Authors: [Antioch Peverell](mailto:apeverell@protonmail.com), [John Tromp](mailto:john.tromp@gmail.com)
- Start date: Oct 25, 2019
- RFC PR: Edit if merged: [mimblewimble/grin-rfcs#0000](https://github.com/mimblewimble/grin-rfcs/pull/0000)
- Tracking issue: [Edit if merged with link to tracking github issue]
Copy link
Contributor

@DavidBurkett DavidBurkett Dec 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this to point to: mimblewimble/grin#3173

- Title: enable-faster-sync
- Authors: [Antioch Peverell](mailto:apeverell@protonmail.com), [John Tromp](mailto:john.tromp@gmail.com)
- Start date: Oct 25, 2019
- RFC PR: Edit if merged: [mimblewimble/grin-rfcs#0000](https://github.com/mimblewimble/grin-rfcs/pull/0000)
Copy link
Contributor

@DavidBurkett DavidBurkett Dec 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be RFC 0009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants