Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Lifecycle Implementation, Pt. 1 #211

Merged
merged 17 commits into from Sep 2, 2019

Conversation

@yeastplume
Copy link
Member

commented Aug 21, 2019

WIP, aims to add to the V3 API:

  • set/get_top_level_directory
  • create_config_file
  • open_wallet
  • close_wallet

Also of note:

  • Changes V3 API to return properly formatted JSON-RPC error responses for internal errors (instead of V2 OK json_rpc response containing an error string)
  • Allows the wallet owner_api to run without a wallet or wallet configuration file being present anywhere
yeastplume added 2 commits Aug 21, 2019
yeastplume added 13 commits Aug 22, 2019

@yeastplume yeastplume changed the title [WIP] API Lifecycle Implementation, Pt. 1 API Lifecycle Implementation, Pt. 1 Aug 30, 2019

@yeastplume

This comment has been minimized.

Copy link
Member Author

commented Aug 30, 2019

Ready for review/comment now

@lehnberg

This comment has been minimized.

Copy link
Collaborator

commented Aug 30, 2019

Partially addresses #212

@lehnberg lehnberg added this to the 2.1.0 milestone Aug 30, 2019

@yeastplume yeastplume merged commit 41c0058 into mimblewimble:master Sep 2, 2019

9 checks passed

mimblewimble.grin-wallet Build #20190830.2 succeeded
Details
mimblewimble.grin-wallet (linux config/libwallet/api) linux config/libwallet/api succeeded
Details
mimblewimble.grin-wallet (linux controller/all) linux controller/all succeeded
Details
mimblewimble.grin-wallet (linux impls) linux impls succeeded
Details
mimblewimble.grin-wallet (linux release) linux release succeeded
Details
mimblewimble.grin-wallet (macos release) macos release succeeded
Details
mimblewimble.grin-wallet (macos test) macos test succeeded
Details
mimblewimble.grin-wallet (windows release) windows release succeeded
Details
mimblewimble.grin-wallet (windows test) windows test succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.