Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `check_version` function to Foreign API #87

Merged
merged 8 commits into from Apr 24, 2019

Conversation

Projects
None yet
1 participant
@yeastplume
Copy link
Member

commented Apr 23, 2019

Adds a check_version function to the foreign API, which currently returns:

  • default_slate_version - CURRENT_SLATE_VERSION
  • foreign_api_version - Version of the foreign API (currently 2)

Idea is that callers have a function they can use to check if a wallet listener is running, and well as determine whether they're compatible and which version of the slate to send if not.

Also a bit of refactoring to make types exposed by the libwallet crate more explicit.

yeastplume added some commits Apr 23, 2019

@yeastplume yeastplume merged commit d774272 into mimblewimble:master Apr 24, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

garyyu added a commit to gottstech/grin-wallet that referenced this pull request Apr 26, 2019

merge from upstream (#5)
* V2 slate versioning enablement (mimblewimble#85)

* fix for command line listener port override

* reduce parameter query size

* Add slate versioning

* rustfmt

* bump version number

* Add tests for slate version conversion

* rustfmt

* Updates and test addition based on bdap's review

* rustfmt

* fix mimblewimble#88 (mimblewimble#89)

* Add `check_version` function to Foreign API (mimblewimble#87)

* move api deser types into separate types mod

* rustfmt

* missing types file

* make all exports from libwallet more explicit

* rustfmt

* add version check function to foreign api

* rustfmt

* change check_version return value to result, for consistency

* fix the merge missed parts

* rustfmt

@yeastplume yeastplume referenced this pull request Apr 30, 2019

Closed

Add /version API #95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.