New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard fork tryout: better PoW encapsulation in block header #1478

Merged
merged 6 commits into from Sep 10, 2018

Conversation

Projects
None yet
2 participants
@ignopeverell
Member

ignopeverell commented Sep 5, 2018

Introducing a struct to encapsulate all PoW fields. This has the effect to reorder block header fields.

@tromp

This comment has been minimized.

Show comment
Hide comment
@tromp

tromp Sep 5, 2018

Contributor

Will it also add the scaling factor for secondary PoW?

Contributor

tromp commented Sep 5, 2018

Will it also add the scaling factor for secondary PoW?

@ignopeverell

This comment has been minimized.

Show comment
Hide comment
@ignopeverell

ignopeverell Sep 5, 2018

Member

Just add it and keep it unused for now? Wasn't planning on adding seconday PoW validation, factor adjustment, etc

Member

ignopeverell commented Sep 5, 2018

Just add it and keep it unused for now? Wasn't planning on adding seconday PoW validation, factor adjustment, etc

@tromp

This comment has been minimized.

Show comment
Hide comment
@tromp

tromp Sep 5, 2018

Contributor

Yep; just add "for future use". Makes hard-fork slightly more interesting due to change in header size.

Contributor

tromp commented Sep 5, 2018

Yep; just add "for future use". Makes hard-fork slightly more interesting due to change in header size.

@ignopeverell

This comment has been minimized.

Show comment
Hide comment
@ignopeverell

ignopeverell Sep 5, 2018

Member

Alright then, I'll add that up.

Member

ignopeverell commented Sep 5, 2018

Alright then, I'll add that up.

ignopeverell added some commits Sep 5, 2018

@ignopeverell

This comment has been minimized.

Show comment
Hide comment
@ignopeverell

ignopeverell Sep 8, 2018

Member

Ready for review from whoever wants to.

Member

ignopeverell commented Sep 8, 2018

Ready for review from whoever wants to.

@ignopeverell ignopeverell merged commit ecf2060 into mimblewimble:master Sep 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment