New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet recovery phrase security fixes #2276

Merged
merged 4 commits into from Jan 2, 2019

Conversation

Projects
None yet
2 participants
@yeastplume
Copy link
Member

yeastplume commented Jan 2, 2019

@ignopeverell Supersedes #2201, using the linefeed crate to parse the recovery phrase in a more user-friendly way.

All other fixes included, except for creating a directory if seed fine directory doesn't exist. I don't think that makes sense as the recovery process is assuming all other wallet files are in place. When recovering from scratch, the process is currently to grin wallet init, delete the seed file, then grin wallet restore.

@yeastplume yeastplume requested a review from ignopeverell Jan 2, 2019

@ignopeverell
Copy link
Member

ignopeverell left a comment

Thanks for finishing this up, looks great!

@ignopeverell ignopeverell merged commit d9ff8e2 into mimblewimble:master Jan 2, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment