Fix handling of IO WouldBlock error in Stratum server #2528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If WouldBlock error happens Stratum server drops part of a message to read or write. This PR inroduces a worker's buffer to store partially read message which will be completed next time. For write the existing util function is used. Fixes mimblewimble#2524
ignopeverell
approved these changes
Feb 12, 2019
|
@hashmap Could you explain it a bit please? :-) |
|
@hendi that’s the purpose of the buffer. It’s a long lived object, if we read the entire line we clear the buffer and return content. If we read a part of the line and about to block we exit and read the rest to the same buffer on the next round. Does it make sense? |
|
Worth mentioning that read_line appends to the provided buffer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If WouldBlock error happens Stratum server drops part of a message to
read or write. This PR introduces a worker's buffer to store partially
read message which will be completed next time. For write the existing
util function is used.
Fixes #2524