Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up CI with Azure Pipelines #2744

Merged

Conversation

Projects
None yet
3 participants
@quentinlesceller
Copy link
Member

commented Apr 10, 2019

Replace #2742 and fix #2691.

While GitLab is a great candidate for CI, it does not support macOS and Windows builds with the SaaS solution.

This PR adds Azure Pipelines as Grin CI.

Pros:

Cons:

  • No caching yet (but it is in the pipeline).
  • Microsoft.
  • Documentation scattered and not always super clear.

To do:
Complete release process with Azure Pipelines.

Example of build process here:

If you don't like the facts that there is 12 tasks running on GitHub I can always let it display as one task.

If this is accepted next steps would be to:

quentinlesceller added some commits Apr 11, 2019

@ignopeverell
Copy link
Member

left a comment

I've got nothing against the Microsoft of the last 5 years and this looks very nice indeed, especially being able to do CI across all the platforms we support. Ping me to enable on our repo, I assume I need an Azure account?

quentinlesceller added some commits Apr 11, 2019

@quentinlesceller

This comment has been minimized.

Copy link
Member Author

commented Apr 11, 2019

I guess you need to create an Azure account. I'll let you know when to merge I'm trying to do the GitHub release process and once that is done we'll be able to merge.

@ignopeverell

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

Where are we at with Azure CI? This PR needs some minor conflict fix.

@quentinlesceller

This comment has been minimized.

Copy link
Member Author

commented Apr 15, 2019

@ignopeverell as you can see I needed some cleanup #2752., in order to fix Windows CI Test on Azure Pipeline CI. You can follow my progress on GitHub and on Azure. Windows tests are still not passing but I'm making very good progress.
Fixing the merge conflict btw.

@quentinlesceller quentinlesceller referenced this pull request Apr 15, 2019

Closed

[WIP] Simplify servers tests #2755

1 of 2 tasks complete

@quentinlesceller quentinlesceller force-pushed the quentinlesceller:azure-pipelines branch from 63a0a81 to fa70bcc May 2, 2019

@quentinlesceller

This comment has been minimized.

Copy link
Member Author

commented May 2, 2019

Okay this is done here is an example of what a release looks like: https://github.com/quentinlesceller/grin/releases.
The changelog is not as nice though (but it still can be generated manually if needed).
@ignopeverell I'll need the name of the connection and I'll update the yml file.
Once this is done we can merge and proceed to a test beta release @yeastplume.
IMO we should keep Travis file around in case we want to switch back (but just disable the check).

@quentinlesceller quentinlesceller merged commit 567ed95 into mimblewimble:master May 9, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.