Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-party bulletproof #24

Merged
merged 16 commits into from Sep 16, 2018

Conversation

@jaspervdm
Copy link
Member

commented Sep 6, 2018

Add support for creating bulletproofs with multiple parties.

  • Figure out if we can simplify the 3 new BP methods, since they contain a lot of the same code as the original
  • Add documentation of arguments
  • Tests

Here is a short explanation of how to create a multi-party BP: https://i.imgur.com/s7exNSf.png

@yeastplume

This comment has been minimized.

Copy link
Member

commented Sep 12, 2018

I think that looks good for the time being. It's probably possible to refactor somewhat to make the API cleaner, but since the upstream implementation is still in development I'd rather we kept as close to that as possible to avoid merge headaches. So all good by me.

And thanks for fixing the tests, just realised I forgot to do that on the C side when I added the message

@jaspervdm

This comment has been minimized.

Copy link
Member Author

commented Sep 15, 2018

The tests succesfully generate and verify 2 to 10 party proofs, so this is in my opinion now ready to be merged in.

@jaspervdm jaspervdm changed the title [WIP] Multi-party bulletproof Multi-party bulletproof Sep 15, 2018

@yeastplume

This comment has been minimized.

Copy link
Member

commented Sep 16, 2018

👍

@yeastplume yeastplume merged commit f1b4f08 into mimblewimble:master Sep 16, 2018

@jaspervdm jaspervdm deleted the jaspervdm:bp_multisig branch Sep 26, 2018

@yeastplume yeastplume referenced this pull request Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.