Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacktrace line numbers in @defcomp Macro #374

Open
lrennels opened this issue Dec 15, 2018 · 2 comments
Assignees
Labels
bug
Milestone

Comments

@lrennels
Copy link
Collaborator

@lrennels lrennels commented Dec 15, 2018

This most recently came up when I was helping to debug some code for Helen and found that the stacktrace for the missing access uses the macro expansion line numbers, making it cumbersome to hunt down which indexing expression causes a problem. Maybe this is just the way it is, especially without a debugger, but we could brainstorm a way to improve it if possible.

@lrennels lrennels added this to the Backlog milestone Dec 15, 2018
@davidanthoff davidanthoff added the bug label Feb 15, 2019
@davidanthoff davidanthoff modified the milestones: Backlog, v0.6.4 Feb 15, 2019
@davidanthoff davidanthoff self-assigned this Feb 15, 2019
@rjplevin

This comment has been minimized.

Copy link
Collaborator

@rjplevin rjplevin commented Feb 20, 2019

A simple one-line fix (for each of run_timestep and init) cures this. See new PR.

@rjplevin rjplevin closed this Feb 20, 2019
@lrennels lrennels reopened this Sep 24, 2019
@lrennels

This comment has been minimized.

Copy link
Collaborator Author

@lrennels lrennels commented Sep 24, 2019

I am reopening this issue per this discussion: https://forum.mimiframework.org/t/improve-missing-data-error-message/96/3 where the error message doesn't seem to be correct ... but it seems we should have solved this here. Talking to Frank to see if the line number was correct.

@davidanthoff davidanthoff modified the milestones: v0.6.4, v1.0.1 Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.