Change logic that checks if all threads are done. Future is much more appropriate for this purpose. #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…appropriated for this purpose.
victorlaerte
changed the title
|
This looks great, thank you! It looks like it might be a good idea to convert WorkerRunnable to Callable to better handle exceptions. What do you think? |
|
@mimno sure. I'll take a deeper look into this, I didn't know if you still merging pull requests. But if so I'll improve this. |
|
I don't have much time to review them. This is a priority, though. |
|
@mimno I've seen you already implemented all the improvements for this PR. Great job. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.