-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dynamic oracle loading (sklearn version) #168
Conversation
…-learn (sklearn) 0.23/0.24/1.0
For me, it looks like this is problem is solved. Thanks for the support & maintenannce |
…rd2/jnk3/gsk3b}_current.pkl
@jannisborn |
Hi @futianfan |
Thanks! it would be really great if you could release a new version :) |
Thanks Jannis! We do plan to release a version in the next week |
HI @kexinhuang12345, any updates on this? |
Hi Jannis, sorry for the delay. We were planning to release it with #161 but there is some data upload issue holding the schedule back. Do you need it urgently? if so, we can release it under 0.3.8 today - let me know! |
Hi Kexin, thanks for the rapid feedback. No it's not super urgent, we were hoping to integrate some more TdC oracles (the ones affected by this PR) into our library and we're getting a bit behind schedule. I dont want to cause you more work, we just prefer installing from PyPI rather than from source, so having a new release anytime soon would be cool :) |
I see that makes sense! how about we will wait for another two days? On Wednesday if the data issue is still not resolved, we will release a new version first. Hope this would work! |
Cool, thanks a lot! |
Hey Jannis, a quick heads up, TDC is just updated to 0.3.7! |
Thanks a ton Kexin, much appreciated 👍🏼 |
Addresses #163
This is a draft PR with a rough sketch. Let's discuss here :)
sklearn
version._sklearn>024
to the filename of the original model on your COSTODO: