Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freedesktop.org.xml file license #97

Closed
hadess opened this issue Mar 24, 2021 · 2 comments
Closed

freedesktop.org.xml file license #97

hadess opened this issue Mar 24, 2021 · 2 comments

Comments

@hadess
Copy link

hadess commented Mar 24, 2021

I've historically been the maintainer of shared-mime-info for around 15 years, and script/freedesktop.org.xml looks like it's a copy of the database shipped with shared-mime-info, which is released under the GPL, with shared-mime-info's translators work merged in, and the GPL header removed.
The license that you're shipping mimemagic under (MIT) isn't compatible with shared-mime-info's.
There are a number of possibilities to fix this problem:

  • change the mimemagic license to be GPL compatible
  • parse the XML file that shared-mime-info ships at runtime, and don't ship it in a codebase with an incompatible license

Using a GPL file as a source makes your whole codebase a derived work, making it all GPL, so I think it's pretty important that this problem gets corrected before somebody uses it in a pure MIT codebase, or a closed-source application.

You will also need to re-add the GPL header to the shared-mime-info XML file as a matter of urgency. It was stripped in release tarballs by the tool used to merge translations, but is visible in the .in version of the same file.

@minad minad closed this as completed in c0f7b6b Mar 24, 2021
@minad
Copy link
Collaborator

minad commented Mar 24, 2021

Thank you for notifying me. I changed the license of the project to GPLv2.

@hadess
Copy link
Author

hadess commented Mar 24, 2021

Thanks a lot for responding this quickly, and the swift resolution, much appreciated :)

JamesGlover pushed a commit to sanger/sequencescape that referenced this issue Mar 24, 2021
*All* versions of mimemagic below 0.3.6 were janked due to
a GPL license violation.

mimemagicrb/mimemagic#97
liamjones referenced this issue in UKGovernmentBEIS/beis-report-official-development-assistance Mar 24, 2021
All versions prior to 0.3.6 have been pulled by the developer, presumably due to a security vulnerability. [1]

[1] Conversation on the repo mimemagicrb/mimemagic#98
mlarraz added a commit to mlarraz/activerecord-multi-tenant that referenced this issue Mar 25, 2021
These don't really make sense for a library, as they are testing just
one out of many possible manifest configurations.

This has the inadvertent effect of fixing the build, as it would
currently be broken due to
mimemagicrb/mimemagic#97 which led to a
dependency being yanked from RubyGems
pcreux pushed a commit to retailzipline/mimemagic that referenced this issue Mar 25, 2021
@mimemagicrb mimemagicrb deleted a comment from icbd Mar 26, 2021
@mimemagicrb mimemagicrb locked as resolved and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants