Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upBetter handling of Rational values in #to_s #26
Conversation
fordhurley
referenced this pull request
Jan 4, 2015
Closed
#to_s doesn't round-trip for some values #22
This comment has been minimized.
This comment has been minimized.
|
Hi, I added you as a collaborator. You can push yourself and just tell we when you think it is ready for a release. Could you also add tests for value_string etc? |
This comment has been minimized.
This comment has been minimized.
|
Great! Specs on value_string was a great idea. |
added a commit
that referenced
this pull request
Jan 8, 2015
fordhurley
merged commit df0fca8
into
minad:master
Jan 8, 2015
1 check failed
continuous-integration/travis-ci
The Travis CI build failed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
fordhurley commentedJan 4, 2015
Added
#value_stringto parallel#unit_string, which does two things when the value isRational:Also added specs for two cases that would fail previously.
Should fix #22.