Better handling of Rational values in #to_s #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added #value_string to parallel #unit_string, which does two things when the value is Rational: - If the denominator is 1, don't show it. - Otherwise, wrap the value in parentheses so that it can be parsed properly. Also added specs for two cases that would fail previously. Should fix minad#22.
|
Hi, I added you as a collaborator. You can push yourself and just tell we when you think it is ready for a release. Could you also add tests for value_string etc? |
|
Great! Specs on value_string was a great idea. |
fordhurley
added a commit
that referenced
this pull request
Jan 8, 2015
Better handling of Rational values in #to_s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
#value_stringto parallel#unit_string, which does two things when the value isRational:Also added specs for two cases that would fail previously.
Should fix #22.