New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing rspec #27

Merged
merged 3 commits into from Jan 9, 2015

Conversation

Projects
None yet
2 participants
@fordhurley
Copy link
Collaborator

fordhurley commented Jan 8, 2015

As I understand it, rspec was trying to call #to_ary on some numeric values for formatting (not sure the details there). This was hitting method_missing and trying to convert the method name to a unit. Now calls super if the method name isn't defined as a unit.

Fix failing rspec
As I understand it, rspec was trying to call #to_ary on some numeric
values for formatting (not sure the details there). This was hitting
method_missing and trying to convert the method name to a unit. Now
calls super if the method name isn't defined as a unit.
@fordhurley

This comment has been minimized.

Copy link
Collaborator

fordhurley commented Jan 8, 2015

Looks like there are still some failures with certain versions of ruby.

Use Time.now instead of Date.today
I believe this will fix builds for ruby 1.8.7 and jrubies. Pushing so
that travis ci runs it.
@fordhurley

This comment has been minimized.

Copy link
Collaborator

fordhurley commented Jan 9, 2015

The last commit fixes the problem so that the builds now actually run. The rest of the failures are because the code is apparently incompatible with those versions of ruby. I suggest removing them from the travis config and opening branches to fix each of the issues individually. Also adding something to the README about version compatibility.

@minad

This comment has been minimized.

Copy link
Owner

minad commented Jan 9, 2015

I suggest that we drop support for < 1.9.3

fordhurley added a commit that referenced this pull request Jan 9, 2015

@fordhurley fordhurley merged commit 273721d into minad:master Jan 9, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment