Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRM #641

Open
lawrencenull opened this issue Oct 16, 2018 · 5 comments
Open

DRM #641

lawrencenull opened this issue Oct 16, 2018 · 5 comments

Comments

@lawrencenull
Copy link

@lawrencenull lawrencenull commented Oct 16, 2018

I have been looking for a reasonabley simple way to add widevine to electron an came across https://github.com/castlabs/electron-releases from a Google partner. Has anyone tried to use this yet especially in the context of min?

I personally think Min only lacks a few things that could make it a daily driver, support for drm content and webrtc.

@PalmerAL

This comment has been minimized.

Copy link
Collaborator

@PalmerAL PalmerAL commented Oct 18, 2018

I have no idea if this works or not, but we're not going to include it in the prebuilt releases regardless. According to that page, in order to include widevine you have to get a special license agreement from Google and have your package codesigned by them, which isn't something I really want to do (and it probably isn't feasible anyway). The fact that this is an Electron fork is also a problem, because it's probably not going to be updated very regularly.

The Electon docs suggest you can just use the Widevine binary included with Chrome. I'm not really sure if this is violating a license agreement or not, so I don't plan on doing it, but that might be something you could investigate.

WebRTC should be supported, the issue is that we don't support permission requests for camera/microphone/etc - that's issue #332.

@lawrencenull

This comment has been minimized.

Copy link
Author

@lawrencenull lawrencenull commented Oct 18, 2018

Thanks for the response. I can understand from the licensing point of view, I'll see if I can make a hack(y) try at it.

@dbfreem

This comment has been minimized.

Copy link

@dbfreem dbfreem commented Jun 12, 2019

@PalmerAL it sounds like this should be closed or at a minimum renamed to reflect the webRTC part only. Thoughts?

@lawrencenull

This comment has been minimized.

Copy link
Author

@lawrencenull lawrencenull commented Jun 14, 2019

Agree, if DRM isn't in the future webrtc would still be a nice addition.

@PalmerAL

This comment has been minimized.

Copy link
Collaborator

@PalmerAL PalmerAL commented Jun 18, 2019

@dbfreem The second issue isn't really webRTC (that's already supported), but that we don't support permission requests for camera and microphone, which there's already an issue for, so I think this issue is just the DRM part.

If we could figure out the licensing issues, I think it would be nice to offer DRM as an optional download (like Firefox does), so maybe this issue should be left open? But given articles like this: https://blog.samuelmaddock.com/posts/google-widevine-blocked-my-browser/, I think that's fairly unlikely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.