Skip to content

MBX-3295: fixed dead lock #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2024
Merged

MBX-3295: fixed dead lock #450

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cb1ef5
MBX-3295: fixed dead lock
Apr 11, 2024
ab762cb
MBX-3295: removed InitializeLock from inAppMutex
Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions sdk/src/main/java/cloud/mindbox/mobile_sdk/Mindbox.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,8 @@ object Mindbox : MindboxLog {

private val mutex = Mutex()

private val inAppMutex = Mutex()

private var firstInitCall: Boolean = true

/**
Expand Down Expand Up @@ -522,7 +524,7 @@ object Mindbox : MindboxLog {
if (activity != null && lifecycleManager.isCurrentActivityResumed) {
inAppMessageManager.registerCurrentActivity(activity)
mindboxScope.launch {
mutex.withLock {
inAppMutex.withLock {
firstInitCall = false
inAppMessageManager.listenEventAndInApp()
inAppMessageManager.initLogs()
Expand Down Expand Up @@ -576,8 +578,8 @@ object Mindbox : MindboxLog {
)
if (firstInitCall) {
mindboxScope.launch {
mutex.withLock {
InitializeLock.await(InitializeLock.State.SAVE_MINDBOX_CONFIG)
InitializeLock.await(InitializeLock.State.SAVE_MINDBOX_CONFIG)
inAppMutex.withLock {
if (!firstInitCall) return@launch
firstInitCall = false
inAppMessageManager.listenEventAndInApp()
Expand Down