Skip to content

Conversation

@kniksees
Copy link
Contributor

@kniksees kniksees commented May 7, 2024

mindbox-cloud/projects/69/views/1?pane=issue&itemId=60704788

@kniksees kniksees requested review from Vailence and sergeysozinov May 7, 2024 17:53
)

if (!messageWasHandled) {
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Здесь бы добавить хотя бы комментарий, в каком случае мы здесь окажемся. Аналогично и для Huawei

google()
mavenCentral()
gradlePluginPortal()

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

лишняя строчка


override fun onMessageReceived(remoteMessage: RemoteMessage) {
super.onMessageReceived(remoteMessage)
val channelId = "test"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тут бы прямо пример, как надо называть

dependencies {
implementation 'androidx.multidex:multidex:2.0.1'
//https://developers.mindbox.ru/docs/firebase-send-push-notifications-flutter
implementation 'cloud.mindbox:mobile-sdk:2.8.5'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

я бы версию mindbox вынес в переменную как ниже для $kotlin_version сделано

@kniksees kniksees merged commit 9be9b7e into feature/MBX-3338-FullExampleFlutter May 15, 2024
kniksees added a commit that referenced this pull request May 16, 2024
* MBX-3338-Example: remove old examples

* MBX-3338-Example: add empty project

* MBX-3338-Example: remove linux

* MBX-3338-Example: remove macos

* MBX-3338-Example: remove web

* MBX-3338-Example: remove windows

* MBX-3338: Full example flutter: flutter segment  (#86)

* MBX-3338-FullExampleFlutter-Flutter: flutter files

* MBX-3338-FullExampleFlutter-Flutter: update flutter

* MBX-3338-FullExampleFlutter-Flutter: update viewmodel

* MBX-3338-FullExampleFlutter-Flutter: update readme

* MBX-3338: Full example flutter: Android segment (#88)

* MBX-3338-FullExampleFlutter-Android: android files

* MBX-3338-FullExampleFlutter-Android: update android

* MBX-3338-FullExampleFlutter-Android: update comments

* MBX-3338-FullExampleFlutter-Android: update android

* MBX-3338: Full example flutter: iOS segment  (#87)

* MBX-3338-FullExampleFlutter-iOS: iOS files

* MBX-3338-FullExampleFlutter-iOS: add bg tasks

* MBX-3338-FullExampleFlutter:add alert
@kniksees kniksees deleted the feature/MBX-3338-FullExampleFlutter-Android branch May 16, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants