Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Removed models.export and added instructions in the documentation #463

Merged
merged 3 commits into from
Sep 13, 2021

Conversation

fg-mindee
Copy link
Contributor

This PR introduces the following modifications:

  • removes the doctr.models.export submodule
  • removes its unittests
  • added corresponding instructions about TFLite in the documentation

Any feedback is welcome!

@fg-mindee fg-mindee added topic: documentation Improvements or additions to documentation module: models Related to doctr.models ext: tests Related to tests folder type: breaking change Introducing a breaking change framework: tensorflow Related to TensorFlow backend labels Sep 13, 2021
@fg-mindee fg-mindee added this to the 0.4.0 milestone Sep 13, 2021
@fg-mindee fg-mindee self-assigned this Sep 13, 2021
@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #463 (7b483a4) into main (148ac00) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #463      +/-   ##
==========================================
- Coverage   95.79%   95.79%   -0.01%     
==========================================
  Files          96       95       -1     
  Lines        4023     3993      -30     
==========================================
- Hits         3854     3825      -29     
+ Misses        169      168       -1     
Flag Coverage Δ
unittests 95.79% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/__init__.py 100.00% <ø> (ø)
...dels/detection/differentiable_binarization/base.py 91.97% <0.00%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 148ac00...7b483a4. Read the comment docs.

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fg-mindee fg-mindee merged commit d755073 into main Sep 13, 2021
@fg-mindee fg-mindee deleted the tf-export branch September 13, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: tests Related to tests folder framework: tensorflow Related to TensorFlow backend module: models Related to doctr.models topic: documentation Improvements or additions to documentation type: breaking change Introducing a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants