Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Refactored detection set and adds CI check #491

Merged
merged 19 commits into from
Sep 29, 2021
Merged

refactor: Refactored detection set and adds CI check #491

merged 19 commits into from
Sep 29, 2021

Conversation

fg-mindee
Copy link
Contributor

@fg-mindee fg-mindee commented Sep 27, 2021 •
edited
Loading

This PR introduces the following modifications:

  • updates the annotation format of detection set
  • updates the target computation in detection models
  • updates the reference script
  • adds a CI job to check the detection training script
  • updates unittests
  • updates the README of the training script
  • updates the training requirements.txt

Closes #429

Any feedback is welcome!

@fg-mindee fg-mindee added topic: documentation Improvements or additions to documentation type: breaking change Introducing a breaking change module: datasets Related to doctr.datasets ext: references Related to references folder topic: text detection Related to the task of text detection labels Sep 27, 2021
@fg-mindee fg-mindee added this to the 0.4.1 milestone Sep 27, 2021
@fg-mindee fg-mindee self-assigned this Sep 27, 2021
@codecov
Copy link

codecov bot commented Sep 27, 2021 •
edited
Loading

Codecov Report

Merging #491 (b79aa84) into main (f8c9af1) will increase coverage by 11.07%.
The diff coverage is 92.85%.

❗ Current head b79aa84 differs from pull request most recent head 2516a38. Consider uploading reports for the commit 2516a38 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             main     #491       +/-   ##
===========================================
+ Coverage   83.93%   95.00%   +11.07%     
===========================================
  Files         109      108        -1     
  Lines        4188     4181        -7     
===========================================
+ Hits         3515     3972      +457     
+ Misses        673      209      -464
Flag Coverage Δ
unittests 95.00% <92.85%> (+11.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/datasets/detection.py 96.96% <92.85%> (ø)
doctr/models/predictor/pytorch.py 38.46% <0.00%> (-28.21%) ⬇️
doctr/models/recognition/crnn/pytorch.py 98.90% <0.00%> (-1.10%) ⬇️
...s/detection/differentiable_binarization/pytorch.py 97.43% <0.00%> (-0.86%) ⬇️
doctr/models/predictor/tensorflow.py 100.00% <0.00%> (ø)
doctr/models/predictor/base.py
doctr/datasets/datasets/base.py 95.55% <0.00%> (+2.22%) ⬆️
doctr/models/detection/core.py 97.61% <0.00%> (+2.38%) ⬆️
...dels/detection/differentiable_binarization/base.py 91.97% <0.00%> (+4.32%) ⬆️
doctr/utils/multithreading.py 100.00% <0.00%> (+9.09%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8c9af1...2516a38. Read the comment docs.

@fg-mindee fg-mindee removed the request for review from charlesmindee September 27, 2021 17:55
charlesmindee
charlesmindee previously approved these changes Sep 28, 2021
View reviewed changes
Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fg-mindee fg-mindee mentioned this pull request Sep 28, 2021
Closed
7 tasks
charlesmindee
charlesmindee previously approved these changes Sep 29, 2021
View reviewed changes
Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

charlesmindee
charlesmindee previously approved these changes Sep 29, 2021
View reviewed changes
Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fg-mindee fg-mindee added the module: models Related to doctr.models label Sep 29, 2021
charlesmindee
charlesmindee previously approved these changes Sep 29, 2021
View reviewed changes
Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

charlesmindee
charlesmindee approved these changes Sep 29, 2021
View reviewed changes
Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@fg-mindee fg-mindee merged commit 007c68e into main Sep 29, 2021
@fg-mindee fg-mindee deleted the det-set branch September 29, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesmindee charlesmindee charlesmindee approved these changes

Assignees

@fg-mindee fg-mindee

Labels
ext: references Related to references folder module: datasets Related to doctr.datasets module: models Related to doctr.models topic: documentation Improvements or additions to documentation topic: text detection Related to the task of text detection type: breaking change Introducing a breaking change
Projects
None yet
Milestone
0.4.1
Development

Successfully merging this pull request may close these issues.

[tests] Add CI jobs to check all scripts outside of the core codebase
2 participants
@fg-mindee @charlesmindee