Skip to content

Add async CLI support #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 10, 2023
Merged

Add async CLI support #131

merged 14 commits into from
May 10, 2023

Conversation

@sebastianMindee
Copy link
Collaborator

@sebastianMindee sebastianMindee commented May 9, 2023

Description

Breaking Changes:

  • New keyword parse in CLI is now required to parse older commands (see the guide for more detail).

Additions:

  • Added support for asynchronous requests in CLI
  • Added Invoice Splitter support in CLI (asynchronous)
  • Refactored CLI code to accommodate for future additions
  • Added keywords enqueue and parse-queued in CLI

Bug fixes:

  • Fixed InvoiceSplitterV1 auto-documentation page
  • Fixed HTTP message display error from parse_queued jobs
  • Fixed delay calculation for asynchronous job completion

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

@sebastianMindee sebastianMindee requested a review from ianardee May 9, 2023 14:21
@sebastianMindee sebastianMindee marked this pull request as ready for review May 9, 2023 16:18
ianardee
ianardee requested changes May 9, 2023
View reviewed changes
sebastianMindee
sebastianMindee commented May 10, 2023
View reviewed changes
Copy link
Collaborator Author

@sebastianMindee sebastianMindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sebastianMindee sebastianMindee merged commit 79eabd9 into main May 10, 2023
@sebastianMindee sebastianMindee deleted the add-async-CLI branch May 10, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ianardee ianardee ianardee approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sebastianMindee @ianardee