From 7724a7cd878f17b59fdb6b8d4a6ab98b851d0c67 Mon Sep 17 00:00:00 2001 From: sebastianMindee Date: Fri, 10 Nov 2023 12:03:33 +0100 Subject: [PATCH 1/3] :bug: fix custom APIs breaking on missing page id --- mindee/parsing/custom/list.py | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/mindee/parsing/custom/list.py b/mindee/parsing/custom/list.py index 23b90bb2..ebc14b7f 100644 --- a/mindee/parsing/custom/list.py +++ b/mindee/parsing/custom/list.py @@ -41,14 +41,18 @@ def __init__( ) -> None: self.values = [] self.reconstructed = reconstructed - if page_id is None: - self.page_id = raw_prediction["page_id"] - else: - self.page_id = page_id - self.confidence = raw_prediction["confidence"] for value in raw_prediction["values"]: self.values.append(ListFieldValueV1(value)) + if page_id is None: + if "page_id" in value: + page_id = value["page_id"] + elif "page_id" in raw_prediction: + self.page_id = raw_prediction["page_id"] + else: + self.page_id = page_id + + self.confidence = raw_prediction["confidence"] @property def contents_list(self) -> List[str]: From 5e2e58a40e3a8006f1a30db0073dc30668c1f8af Mon Sep 17 00:00:00 2001 From: sebastianMindee Date: Fri, 10 Nov 2023 12:13:38 +0100 Subject: [PATCH 2/3] fix syntax --- mindee/parsing/custom/list.py | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/mindee/parsing/custom/list.py b/mindee/parsing/custom/list.py index ebc14b7f..6607cbc5 100644 --- a/mindee/parsing/custom/list.py +++ b/mindee/parsing/custom/list.py @@ -44,14 +44,14 @@ def __init__( for value in raw_prediction["values"]: self.values.append(ListFieldValueV1(value)) - if page_id is None: - if "page_id" in value: - page_id = value["page_id"] - elif "page_id" in raw_prediction: - self.page_id = raw_prediction["page_id"] - else: - self.page_id = page_id - + if "page_id" in value: + page_id = value["page_id"] + + if page_id is None: + if "page_id" in raw_prediction: + self.page_id = raw_prediction["page_id"] + else: + self.page_id = page_id self.confidence = raw_prediction["confidence"] @property From 4f80b5a0fd15e9debd05756986f62bee4683eb65 Mon Sep 17 00:00:00 2001 From: sebastianMindee Date: Fri, 10 Nov 2023 12:16:05 +0100 Subject: [PATCH 3/3] add typing --- mindee/parsing/custom/list.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mindee/parsing/custom/list.py b/mindee/parsing/custom/list.py index 6607cbc5..b6aed712 100644 --- a/mindee/parsing/custom/list.py +++ b/mindee/parsing/custom/list.py @@ -28,7 +28,7 @@ class ListFieldV1: """Confidence score""" reconstructed: bool """Whether the field was reconstructed from other fields.""" - page_id: int + page_id: Optional[int] """The document page on which the information was found.""" values: List[ListFieldValueV1] """List of word values"""