Skip to content

Conversation

@ianardee
Copy link
Contributor

Print the invoice locale

Description

Add some typing
Print the locale in Invoice and Receipt
Print the company numbers in Invoice

Motivation and Context

Some users will assume information not present when printing a document is missing.

How Has This Been Tested

Added unit tests

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ianardee
Copy link
Contributor Author

CC @xaviermindee

Copy link
Contributor

@fharper fharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ianardee ianardee merged commit 3051e66 into main Feb 18, 2022
@ianardee ianardee deleted the print-locale branch February 18, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants