New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing the Gmail Application Handler #5889
Conversation
|
I have read the CLA Document and I hereby sign the CLA -- rajeev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the Pull Request! Main changes I'd like to see before merging:
- Add basic tests
- Add example for
SELECTrow in docs
|
Thanks a lot @tmichaeldb for reviewing the PR. I'll mostly be making the requested changes today. Should I change the column name "from" to something else (say sender) to avoid clashes with SQL reserved keywords? Thanks, |
|
The Checks are failing because of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please don't merge yet though due to figuring out how to combine this PR with #5890 .
|
Amazing, @ra-jeev , @maarioos1308 is this ready? |
Hey @ZoranPandovski, I think it should be ready by tomorrow. (@maarioos1308 added attachments parsing today). Also, IMO, it was duplicate content so I had not added it in my PR, but @maarioos1308 had it. |
|
Hey @ZoranPandovski & @tmichaeldb,
Things to note
Both of these can be added if you think we need to have it. But for downloads I've a concern for the attachments size. Once this PR is merged we can close #5890. Then I can do one more change related to creating email drafts which is not supported yet. Thanks, |
|
Excellent, thanks, team, and congratulations on winning the first prize :trophy: . Please feel free to open an issue for all of the new features :raised_hands: |
|
Thanks a lot @ZoranPandovski :-) |
Description
Please include a summary of the change and the issue it solves.
Fixes #5364
Type of change
What is the solution?
Implemented the Gmail Application Handler using the Gmail API with the help of
google-api-python-clientandgoogle-auth-oauthliblibraries. The integration supports pulling emails from the OAuth authenticated user's Gmail mailbox using the filter queries supported by Gmail. It then extracts the text and other relevant details from the individual emails and add it to the database. It also supports sending text emails to the destination email address by using theInsertcommand. It also supports creating threads in case of replying to emails.Checklist: