fix(docker): fix env path in dockerfile #90
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What does this PR do / why do we need it:
In the
1.0.0
Docker image, pip is configured in a way that all command line entrypoints are installed into/root/.local/bin
. However,/root/.local/bin
is not in thePATH
env variables. This causes the problem that all Python packages that have CLI interfaces will throw "Command not found" error.For example,
In this particular case, one workaround is to use
python -m pytest
. However, not all CLI-enabled packages implement this usage.Which issue(s) this PR fixes:
This PR adds
/root/.local/bin
to envPATH
inside Mindspore Dockerfile, so that all images built on top ofmindspore
will not suffer from this usability issue.Special notes for your reviewers:
Please note that this should be applied to all Dockerfiles. Right now I'm just fixing one to showcase the problem and confirm with your dev team to see if this is the way to go.