fix(docker): fix env path in dockerfile#90
Conversation
|
Welcome @hanxiao! |
|
Hi @hanxiao. Thanks for your PR. I'm waiting for a mindspore-ai member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hi @hanxiao , sorry for the late replies. We want to let you know that this PR has been transferred into MindSpore Gitee repo: https://gitee.com/mindspore/mindspore/pulls/8549, and we will keep u noticed with the latest PR update : ) |
|
Hi @hanxiao, please notice that the cloned Gitee PR (https://gitee.com/mindspore/mindspore/pulls/8549) has been approved and merged into the codebase, so this PR would be closed. Thanks for your contribution! |
What type of PR is this?
/kind bugWhat does this PR do / why do we need it:
In the
1.0.0Docker image, pip is configured in a way that all command line entrypoints are installed into/root/.local/bin. However,/root/.local/binis not in thePATHenv variables. This causes the problem that all Python packages that have CLI interfaces will throw "Command not found" error.For example,
In this particular case, one workaround is to use
python -m pytest. However, not all CLI-enabled packages implement this usage.Which issue(s) this PR fixes:
This PR adds
/root/.local/binto envPATHinside Mindspore Dockerfile, so that all images built on top ofmindsporewill not suffer from this usability issue.Special notes for your reviewers:
Please note that this should be applied to all Dockerfiles. Right now I'm just fixing one to showcase the problem and confirm with your dev team to see if this is the way to go.