Skip to content

Conversation

@develop-chen
Copy link
Contributor

新增按照属性在代码中的顺序排序方案 兼容index方案
有以下问题可能需要解决:
如果只有部分字段定义了index 分以下情况
情况1:属性排在第3个 如果都不加index 属性默认的键就是2,如果这个元素加了index=1 则会把键为1的元素覆盖
情况2:属性排在第3个 如果都不加index 属性默认的键就是2,如果这个元素加了index=100 则从这个元素开始的键名是从100开始递增,目前未发现副作用
建议解决方案:仅允许全部都添加index或者全部都不添加index 非正常情况都报错提示

@boring-cyborg boring-cyborg bot added the Office label May 10, 2024
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 10, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented May 10, 2024

Thanks for opening this pull request! Please check out our contributing guidelines.

@dosubot dosubot bot added the enhancement New feature or request label May 10, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels May 10, 2024
@zds-s zds-s marked this pull request as draft May 11, 2024 07:45
@zds-s zds-s marked this pull request as ready for review May 13, 2024 10:16
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels May 13, 2024
@zds-s zds-s merged commit af2ebe3 into mineadmin:2.0 May 13, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented May 13, 2024

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Office size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants