Skip to content

Conversation

@BadJacky
Copy link
Contributor

No description provided.

@BadJacky BadJacky marked this pull request as ready for review June 15, 2024 10:19
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Jun 15, 2024
@codecov
Copy link

codecov bot commented Jun 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 52 lines in your changes missing coverage. Please review.

Project coverage is 3.90%. Comparing base (421878d) to head (3ad9147).

Files Patch % Lines
src/mine-helpers/src/Str.php 0.00% 14 Missing ⚠️
src/mine-helpers/src/AppVerify.php 0.00% 7 Missing ⚠️
src/Module/src/Command/Migrate/MineMigrate.php 0.00% 6 Missing ⚠️
src/Module/src/Command/Seeder/MineSeeder.php 0.00% 6 Missing ⚠️
...c/Module/src/Command/Creater/CreateFormRequest.php 0.00% 4 Missing ⚠️
src/Module/src/Command/Migrate/MineMigrateRun.php 0.00% 4 Missing ⚠️
src/Module/src/Command/Seeder/MineSeederRun.php 0.00% 4 Missing ⚠️
src/mine-helpers/src/LoginUser.php 0.00% 3 Missing ⚠️
src/Module/src/Command/Creater/CreateModel.php 0.00% 1 Missing ⚠️
...Module/src/Command/Migrate/MineMigrateRollback.php 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@           Coverage Diff           @@
##               2.0     #93   +/-   ##
=======================================
  Coverage     3.90%   3.90%           
- Complexity    2471    2473    +2     
=======================================
  Files          258     258           
  Lines         7275    7275           
=======================================
  Hits           284     284           
  Misses        6991    6991           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BadJacky
Copy link
Contributor Author

@zds-s

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 15, 2024
@zds-s
Copy link
Member

zds-s commented Jun 15, 2024

module 想去掉。和应用商店的插件冲突 @BadJacky .要不直接存档这个库?

@BadJacky
Copy link
Contributor Author

module 想去掉。和应用商店的插件冲突 @BadJacky .要不直接存档这个库?

这应该是两件事情,和这个 pr 的关系也不太大,建议开一个 discussion 看看什么反馈。

@zds-s zds-s merged commit fb978fc into mineadmin:2.0 Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request JwtAuth lgtm This PR has been approved by a maintainer MineGenerator MineHelpers Module size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants