Skip to content

Fix default value of vulnerability_alerts #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2021
Merged

Fix default value of vulnerability_alerts #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f936748
fix: always set correct value for vulnerability_alerts to avoid drifts
soerenmartius Aug 3, 2021
559b9bd
chore: prepare v0.10.1 release
soerenmartius Aug 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [0.10.1]

### Fixed

- Set `vulnerability_alerts` per default to `true` for public repositories and
to `false` for private repositories if not explicitly set to avoid drifts
when running `terraform plan`.

## [0.10.0]

### Added
Expand Down Expand Up @@ -262,11 +270,12 @@ Please review plans and report regressions and issues asap so we can improve doc

<!-- markdown-link-check-disable -->

[unreleased]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.10.0...HEAD
[0.10.0]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.9.2...v1.0.0
[unreleased]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.10.1...HEAD
[0.10.1]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.10.0...v0.10.1

<!-- markdown-link-check-enable -->

[0.10.0]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.9.2...v0.10.0
[0.9.2]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.9.1...v0.9.2
[0.9.1]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.9.0...v0.9.1
[0.9.0]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.8.0...v0.9.0
Expand Down
4 changes: 3 additions & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ locals {
gh_labels = local.var_gh_labels == null ? lookup(var.defaults, "issue_labels_merge_with_github_labels", true) : local.var_gh_labels

issue_labels_merge_with_github_labels = local.gh_labels
# Per default, GitHub activates vulnerability alerts for public repositories and disables it for private repositories
vulnerability_alerts = var.vulnerability_alerts != null ? var.vulnerability_alerts : local.private ? false : true
}

locals {
Expand Down Expand Up @@ -106,7 +108,7 @@ resource "github_repository" "repository" {
topics = local.topics

archive_on_destroy = var.archive_on_destroy
vulnerability_alerts = var.vulnerability_alerts
vulnerability_alerts = local.vulnerability_alerts

dynamic "template" {
for_each = local.template
Expand Down