-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make modpack mostly independent from MTG #607
Conversation
Nice. |
I'm not sure about changing the list in mesecons_mvps, since mods might want to register the MVPS stoppers for themselves. |
I don't understand the concern here. There is a hardcoded list of nodes in the mod, surely it should only apply when MTG is detected? |
Yes, my thought is that the list should apply only when MTG is used, and other games that Mesecons is made compatible with can register their stoppers themselves. |
Then what about moving the hardcoded list to |
Co-authored-by: sfan5 <sfan5@live.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works, tested with devtest.
@Tim79000 default contains a lot of unrelated features, many of them specific to Minetest Game and its spin-offs. If a mod depends on default, it basically depends on Minetest Game. |
This PR makes all Mesecons mods except
mesecons_doors
work with any game, and none of the mods hard-depend ondefault
any longer. I added a modmesecons_gamecompat
to handle most external dependencies. The addition of a mod to the pack may cause problems for people updating it, in which case I should put the compatibility code in themesecons
mod or something. In any case, almost the entire modpack will now work with any game, although it requiresdefault
and some other MTG mods to provide sounds etc.mesecons_detectors
depended ondefault
to providedefault_steel_block.png
. To remedy this, I added a copy of the texture to the mod as a fallback (giving appropriate attribution.) I could make the mod use the fallback texture 100% of the time, but this might mess with existing texture packs.If no
mesecons_gamecompat:mese
alias is registered,mesecons_extrawires
provides its own placeholdermesecons_extrawires:mese
. Otherwise,mesecons_extrawires:mese
is an alias of the real mese.Support for more games without the
default
mod can be added in the future by adding more compatibility code tomesecons_gamecompat
.