Updated to the Minetest location format #149 and update the Spanish #150
Conversation
circular_saw.lua
Outdated
| @@ -366,15 +365,17 @@ function circular_saw.on_construct(pos) | |||
| local meta = minetest.get_meta(pos) | |||
| local fancy_inv = default.gui_bg..default.gui_bg_img..default.gui_slots | |||
| meta:set_string( | |||
| --For some reason the translation does not work with @n in this part | |||
There was a problem hiding this comment.
Have you tried
and
Input@nmaterial=Material de@nentrada
? This usually worked on other projects I updated translation system on…
There was a problem hiding this comment.
That is what I have tried, but it does not work, it is strange because in infotext if it works
There was a problem hiding this comment.
Oh, it seems related to this bug minetest/minetest#7450. And this is specific to labels… Maybe you should had a FIXME with a reference to this issue in your comment. Your workaround is fine.
stairsplus/registrations.lua
Outdated
| @@ -158,7 +158,6 @@ minetest.register_lbm({ | |||
| param2 = minetest.get_node(pos).param2 | |||
|
|
|||
| }) | |||
| minetest.log('action', "LBM replaced " .. node.name .. | |||
| " at " .. minetest.pos_to_string(pos)) | |||
| minetest.log('action', S("LBM replaced @1 at @2", node.name, minetest.pos_to_string(pos))) | |||
There was a problem hiding this comment.
translation does not work correctly on minetest.log output
consider removing localization on this string
There was a problem hiding this comment.
What problem does it produce?, I intend to create a server and I would prefer that the logs be in Spanish
There was a problem hiding this comment.
It would be fine, but currently they appear with @moreblocks) in front, and it seems strings are logged in english (translation does only work in client display).
stairsplus/common.lua
Outdated
| } | ||
|
|
||
| stairsplus.register_single = function(category, alternate, info, modname, subname, recipeitem, fields) | ||
| local desc_base = descriptions[category]:format(fields.description) | ||
| local desc_base = S("@1 "..descriptions[category], fields.description) |
There was a problem hiding this comment.
It is better avoiding concatenation.
There was a problem hiding this comment.
What would be the recommended way? I have removed it to avoid the error: ignoring escape sequence 'Tmoreblocks' in translation
There was a problem hiding this comment.
In this kind of function, it is better when full translated description can be given as argument as in some languages descriptions[category] and fields.description are not always in the same order as in english (and also fields.description value can depend on value of descriptions[category] in languages like french) `.
It is ok to keep old parameters and adding an optional new one, and if if the full translated description is nil, fallback to not translated string else description is set to the new parameter. This implies refactoring a bit this function.
There was a problem hiding this comment.
No, @1 @2 doesn't allow to have values of @1 and @2 depending on each other.
I mean, something like
stairsplus.register_single = function(category, alternate, info, modname, subname, recipeitem, fields, fulldescription)and
local desc_base = fields.description..descriptions[category]
-- …
-- if (…) then
-- …
def.description = fulldescription or ("%s (%d/16)"):format(desc_base, info)
-- …
-- else
-- …
def.description = fulldescription and S("@1 (@2/16)", fulldescription, compute_at_2()) or desc_base .. alternate:gsub("_", " "):gsub("(%a)(%S*)", function(a, b) return a:upper() .. b end)and each something Microblock should be fully added in tr files (yes, it is a lot (they are all in stairsplus/registrations.lua), but have a look at translation files of minetest_game/stairs for reference). I can create the resulting template.txt if you want + french translation (but I can not have perfect translation in other languages because word order may varies and words may have different grammatical form depending on categories)
This means stairplus api must be changed, and all its calls… I can also help with this if you need.
There was a problem hiding this comment.
The example above if it works, can't translate all the elements because it depends on the mods installed, on my server there would be 9112 blocks in moreblocks
There was a problem hiding this comment.
Can you give me some examples of mods defining nodes in moreblocks, please (or the name of your server if it is a public one)? In the next couple of days, I will try to implement a backward compatible solution allowing to have better translations if external mods define specific translation strings, but defaulting to same as your implementation. I hope, this would allow all your mods to work well in your language.
There was a problem hiding this comment.
mods:
- bridger
- scifi_nodes
- concrete (technic)
- building_blocks (homedecor_modpack)
The server is still private
There was a problem hiding this comment.
Is 86502f2 working well with your mods? I have tried with technic and can reproduce your screenshot. Some strings like @1 Stair Outer still need to be updated in .tr files.
There was a problem hiding this comment.
It works fine, there are missing strings to translate, but I still don't understand what fulldescs does, I don't notice the difference, maybe in other languages.
What value would fulldescs have?
in technic fields.description = S("Concrete Post Platform") and fulldesc is nil
|
May I re-work this PR? It's something pending since about a year ago. |
Sure 🙂 I wasn't around much to review this PR when it was origiginally made, apologies. |
ghost
closed this
Ready |
|
Superseded by #186. |
-Updated to the Minetest location format #149
-Update the Spanish