This repository was archived by the owner on May 13, 2024. It is now read-only.
Use SDL2 by default - #209
Merged
Merged
Conversation
numberZero
marked this pull request as draft
July 2, 2023 19:16
Contributor
Author
|
Mingw+SDL will apparently require uploading an SDL build to http://minetest.kitsunemimi.pw/. @sfan5 is that yours? UPD: MinGW+SDL CI is in |
ndren
reviewed
Jul 26, 2023
Contributor
There was a problem hiding this comment.
I think lowercase sdl2 was the correct formatting in Brew (the way it was before): https://github.com/Homebrew/homebrew-core/pkgs/container/core%2Fsdl2
Contributor
|
Sorry for the weird formatting, I'm basically suggesting |
Except of Android and macOS, for now
numberZero
marked this pull request as ready for review
November 3, 2023 16:42
Contributor
Author
|
Rebased. |
rubenwardy
approved these changes
Dec 17, 2023
rubenwardy
left a comment
rubenwardy
left a comment
Member
There was a problem hiding this comment.
I deleted my cmake cache and clean built, uses SDL as expected. EndeavourOS Linux
sfan5
reviewed
Dec 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #206.