Skip to content
Browse files

Fix rotate_node to return the correct itemstack.

All on_* hooks that return an itemstack are NOT guaranteed to
modify and return the original stack.  We cannot count on the
behavior of the existing builtin definitions not to be overridden
by game/mod logic.
  • Loading branch information
Warr1024 authored and sfan5 committed Oct 13, 2019
1 parent 47d0779 commit 0df646e0689b5324c7bdb13205c2a63e42ebe8e8
Showing with 1 addition and 2 deletions.
  1. +1 −2 builtin/common/misc_helpers.lua
@@ -428,10 +428,9 @@ if INIT == "game" then
core.rotate_node = function(itemstack, placer, pointed_thing)
local name = placer and placer:get_player_name() or ""
local invert_wall = placer and placer:get_player_control().sneak or false
core.rotate_and_place(itemstack, placer, pointed_thing,
return core.rotate_and_place(itemstack, placer, pointed_thing,
{invert_wall = invert_wall}, true)
return itemstack

0 comments on commit 0df646e

Please sign in to comment.
You can’t perform that action at this time.