Skip to content
Permalink
Browse files

Fix string.split returning an empty table if string starts with sepea…

…rator (#7827)

Calling string.split(":A:B:C:D", ":") returns an empty array.
This is due to first empty string not making repeat loop decreasing max_split which has a 0 value when reaching until.
Changing max_splits default value from -1 to -2 fixes that issue.
  • Loading branch information...
pyrollo authored and SmallJoker committed Nov 1, 2018
1 parent 4d4bfb1 commit 0e306c084284aeafb3d5cde0cfec11a85a11cb9c
Showing with 1 addition and 1 deletion.
  1. +1 −1 builtin/common/misc_helpers.lua
@@ -166,7 +166,7 @@ end
--------------------------------------------------------------------------------
function string.split(str, delim, include_empty, max_splits, sep_is_pattern)
delim = delim or ","
max_splits = max_splits or -1
max_splits = max_splits or -2
local items = {}
local pos, len = 1, #str
local plain = not sep_is_pattern

0 comments on commit 0e306c0

Please sign in to comment.
You can’t perform that action at this time.