Skip to content


Voxelmanip: Do not emerge or blit to blocks over map gen limit
Browse files Browse the repository at this point in the history
Placing a structure that extends into mapblocks that extend past
map_gen_limit causes a crash. For example a sapling growing at the
world edge which adds leaves beyond the edge, or placing a structure
using the lua voxelmanip, or placing a schematic or l-system tree.

Do not run the 'load_if_inexistent' block of code if the mapblock
is over limit, this also marks the mapblock with the flag
VMANIP_BLOCK_DATA_INEXIST which later prevents blitting back those

This fix therefore uses existing functionality by having the same
effect as the 'load_if_inexistent' bool being false.
  • Loading branch information
paramat committed Feb 18, 2017
1 parent d0a6cac commit 111e7e1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/map.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3161,7 +3161,7 @@ void MMVManip::initialEmerge(v3s16 blockpos_min, v3s16 blockpos_max,

if (load_if_inexistent) {
if (load_if_inexistent && !blockpos_over_limit(p)) {
ServerMap *svrmap = (ServerMap *)m_map;
block = svrmap->emergeBlock(p, false);
if (block == NULL)
Expand Down

0 comments on commit 111e7e1

Please sign in to comment.