Skip to content
Permalink
Browse files

network: Stricter handling of split packets

  • Loading branch information...
sfan5 committed Aug 15, 2019
1 parent c449116 commit 2db0e93f73a4b103bfec469b8ff02edce11399de
Showing with 11 additions and 4 deletions.
  1. +11 −4 src/network/connection.cpp
@@ -417,6 +417,11 @@ SharedBuffer<u8> IncomingSplitBuffer::insert(const BufferedPacket &p, bool relia
<< std::endl;
return SharedBuffer<u8>();
}
if (chunk_num >= chunk_count) {
errorstream << "IncomingSplitBuffer::insert(): chunk_num=" << chunk_num
<< " >= chunk_count=" << chunk_count << std::endl;
return SharedBuffer<u8>();
}

// Add if doesn't exist
if (m_buf.find(seqnum) == m_buf.end()) {
@@ -425,10 +430,12 @@ SharedBuffer<u8> IncomingSplitBuffer::insert(const BufferedPacket &p, bool relia

IncomingSplitPacket *sp = m_buf[seqnum];

if (chunk_count != sp->chunk_count)
LOG(derr_con<<"Connection: WARNING: chunk_count="<<chunk_count
<<" != sp->chunk_count="<<sp->chunk_count
<<std::endl);
if (chunk_count != sp->chunk_count) {
errorstream << "IncomingSplitBuffer::insert(): chunk_count="
<< chunk_count << " != sp->chunk_count=" << sp->chunk_count
<< std::endl;
return SharedBuffer<u8>();
}
if (reliable != sp->reliable)
LOG(derr_con<<"Connection: WARNING: reliable="<<reliable
<<" != sp->reliable="<<sp->reliable

0 comments on commit 2db0e93

Please sign in to comment.
You can’t perform that action at this time.