Skip to content

Commit

Permalink
Only do the IPv6 unit test if IPv6 is enabled
Browse files Browse the repository at this point in the history
  • Loading branch information
@nerzhul
nerzhul committed Feb 15, 2015
1 parent 5eb0eda commit 3b6b943
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/test.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1673,7 +1673,7 @@ struct TestSocket: public TestBase
Address address6((IPv6AddressBytes*) NULL, port);

// IPv6 socket test
{
if (g_settings->getBool("enable_ipv6")) {

This comment has been minimized.

Sign in to view

Copy link
@Zeno-

Zeno- Feb 16, 2015

Contributor

This was my original solution to this long-standing issue. The "problem" I had with it is that it introduces a dependence in the unit tests (that settings are functional, and have also (possibly) been initialised and/or read). I didn't particularly like this.

Anyway since my personal opinion //now// is that test.cpp|h needs some work I have no particular problem with this fix any more.
UDPSocket socket6;

if (!socket6.init(true, true)) {
Expand Down

0 comments on commit 3b6b943

Please sign in to comment.