Skip to content

Commit

Permalink
Add 'persistence' alias for Lua noiseparams and validate more vector …
Browse files Browse the repository at this point in the history
…parameters
  • Loading branch information
kwolekr committed Apr 20, 2015
1 parent 687d969 commit 3d4244c
Show file tree
Hide file tree
Showing 4 changed files with 74 additions and 14 deletions.
18 changes: 10 additions & 8 deletions src/script/common/c_content.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -983,14 +983,16 @@ bool read_noiseparams(lua_State *L, int index, NoiseParams *np)
if (!lua_istable(L, index))
return false;

np->offset = getfloatfield_default(L, index, "offset", 0.0);
np->scale = getfloatfield_default(L, index, "scale", 0.0);
np->persist = getfloatfield_default(L, index, "persist", 0.0);
np->lacunarity = getfloatfield_default(L, index, "lacunarity", 2.0);
np->seed = getintfield_default(L, index, "seed", 0);
np->octaves = getintfield_default(L, index, "octaves", 0);

u32 flags = 0, flagmask = 0;
getfloatfield(L, index, "offset", np->offset);
getfloatfield(L, index, "scale", np->scale);
getfloatfield(L, index, "persist", np->persist);
getfloatfield(L, index, "persistence", np->persist);
getfloatfield(L, index, "lacunarity", np->lacunarity);
getintfield(L, index, "seed", np->seed);
getintfield(L, index, "octaves", np->octaves);

u32 flags = 0;
u32 flagmask = 0;
np->flags = getflagsfield(L, index, "flags", flagdesc_noiseparams,
&flags, &flagmask) ? flags : NOISE_FLAG_DEFAULTS;

Expand Down
52 changes: 52 additions & 0 deletions src/script/common/c_converter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,19 @@ v2s16 read_v2s16(lua_State *L, int index)
return p;
}

v2s16 check_v2s16(lua_State *L, int index)
{
v2s16 p;
luaL_checktype(L, index, LUA_TTABLE);
lua_getfield(L, index, "x");
p.X = luaL_checknumber(L, -1);
lua_pop(L, 1);
lua_getfield(L, index, "y");
p.Y = luaL_checknumber(L, -1);
lua_pop(L, 1);
return p;
}

v2s32 read_v2s32(lua_State *L, int index)
{
v2s32 p;
Expand All @@ -85,6 +98,19 @@ v2f read_v2f(lua_State *L, int index)
return p;
}

v2f check_v2f(lua_State *L, int index)
{
v2f p;
luaL_checktype(L, index, LUA_TTABLE);
lua_getfield(L, index, "x");
p.X = luaL_checknumber(L, -1);
lua_pop(L, 1);
lua_getfield(L, index, "y");
p.Y = luaL_checknumber(L, -1);
lua_pop(L, 1);
return p;
}

v3f read_v3f(lua_State *L, int index)
{
v3f pos;
Expand Down Expand Up @@ -285,6 +311,32 @@ bool getintfield(lua_State *L, int table,
return got;
}

bool getintfield(lua_State *L, int table,
const char *fieldname, u16 &result)
{
lua_getfield(L, table, fieldname);
bool got = false;
if(lua_isnumber(L, -1)){
result = lua_tonumber(L, -1);
got = true;
}
lua_pop(L, 1);
return got;
}

bool getintfield(lua_State *L, int table,
const char *fieldname, u32 &result)
{
lua_getfield(L, table, fieldname);
bool got = false;
if(lua_isnumber(L, -1)){
result = lua_tonumber(L, -1);
got = true;
}
lua_pop(L, 1);
return got;
}

bool getfloatfield(lua_State *L, int table,
const char *fieldname, float &result)
{
Expand Down
6 changes: 6 additions & 0 deletions src/script/common/c_converter.h
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ size_t getstringlistfield(lua_State *L, int table,
std::vector<std::string> *result);
bool getintfield(lua_State *L, int table,
const char *fieldname, int &result);
bool getintfield(lua_State *L, int table,
const char *fieldname, u16 &result);
bool getintfield(lua_State *L, int table,
const char *fieldname, u32 &result);
void read_groups(lua_State *L, int index,
std::map<std::string, int> &result);
bool getboolfield(lua_State *L, int table,
Expand All @@ -72,6 +76,8 @@ void setboolfield(lua_State *L, int table,


v3f checkFloatPos (lua_State *L, int index);
v2f check_v2f (lua_State *L, int index);
v2s16 check_v2s16 (lua_State *L, int index);
v3f check_v3f (lua_State *L, int index);
v3s16 check_v3s16 (lua_State *L, int index);

Expand Down
12 changes: 6 additions & 6 deletions src/script/lua_api/l_noise.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ int LuaPerlinNoise::l_get2d(lua_State *L)
{
NO_MAP_LOCK_REQUIRED;
LuaPerlinNoise *o = checkobject(L, 1);
v2f p = read_v2f(L, 2);
v2f p = check_v2f(L, 2);
lua_Number val = NoisePerlin2D(&o->np, p.X, p.Y, 0);
lua_pushnumber(L, val);
return 1;
Expand All @@ -54,7 +54,7 @@ int LuaPerlinNoise::l_get3d(lua_State *L)
{
NO_MAP_LOCK_REQUIRED;
LuaPerlinNoise *o = checkobject(L, 1);
v3f p = read_v3f(L, 2);
v3f p = check_v3f(L, 2);
lua_Number val = NoisePerlin3D(&o->np, p.X, p.Y, p.Z, 0);
lua_pushnumber(L, val);
return 1;
Expand Down Expand Up @@ -168,7 +168,7 @@ int LuaPerlinNoiseMap::l_get2dMap(lua_State *L)
size_t i = 0;

LuaPerlinNoiseMap *o = checkobject(L, 1);
v2f p = read_v2f(L, 2);
v2f p = check_v2f(L, 2);

Noise *n = o->noise;
n->perlinMap2D(p.X, p.Y);
Expand All @@ -191,7 +191,7 @@ int LuaPerlinNoiseMap::l_get2dMap_flat(lua_State *L)
NO_MAP_LOCK_REQUIRED;

LuaPerlinNoiseMap *o = checkobject(L, 1);
v2f p = read_v2f(L, 2);
v2f p = check_v2f(L, 2);

Noise *n = o->noise;
n->perlinMap2D(p.X, p.Y);
Expand All @@ -213,7 +213,7 @@ int LuaPerlinNoiseMap::l_get3dMap(lua_State *L)
size_t i = 0;

LuaPerlinNoiseMap *o = checkobject(L, 1);
v3f p = read_v3f(L, 2);
v3f p = check_v3f(L, 2);

if (!o->m_is3d)
return 0;
Expand Down Expand Up @@ -243,7 +243,7 @@ int LuaPerlinNoiseMap::l_get3dMap_flat(lua_State *L)
NO_MAP_LOCK_REQUIRED;

LuaPerlinNoiseMap *o = checkobject(L, 1);
v3f p = read_v3f(L, 2);
v3f p = check_v3f(L, 2);

if (!o->m_is3d)
return 0;
Expand Down

0 comments on commit 3d4244c

Please sign in to comment.